Repository navigation
Compare the blob policy verification level as a string - #593
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
October 13, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlobDocument.Validatemeans to forbid a global blob policy from skipping verification, but the comparison cannot fire.SignatureVerification.VerificationLevelis astringholding the level name, whileLevelSkipis a*VerificationLevel, soreflect.DeepEqualis handed two different types and is always false.The sibling in
verifier.go:253runs the same idiom correctly, because thereverificationLevelreally is a*VerificationLevelreturned byGetVerificationLevel. Only the blob document path compares the raw string.There is no second gate behind it.
validatePolicyCorerejectsskipwhen trust stores or trusted identities are set, but permits it when they are absent, which is the shape that reaches this check. So a blob policy document withglobalPolicy: trueandlevel: skipvalidates cleanly today and ends up with every enforcement field set to skip.Comparing against
LevelSkip.Nameis what the field holds, andreflectwas imported only for this line so it goes too.The new case fails on main with
got <nil>fromValidate, and passes here. I added the non-global case beside it, since a statement that is not the global policy is still allowed to use skip and should stay that way. The repo is green, zero failures across all packages.