Skip to content

test: run node-bench tools test sequentially - #66338

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:deflake-bench-tools
Open

panva wants to merge 1 commit into
nodejs:mainfrom
panva:deflake-bench-tools

Conversation

@panva

@panva panva commented Sep 27, 2026

Copy link
Copy Markdown
Member

The test and its benchmark subprocesses allocate large histograms. Run it sequentially to reduce memory pressure on constrained CI hosts. If this re-appears -> pummel.

https://ci.nodejs.org/job/node-test-commit-smartos/68752/nodes=smartos23-x64/testReport/junit/(root)/parallel/test_benchmark_node_bench_tools/

The test and its benchmark subprocesses allocate large histograms.
Run it sequentially to reduce memory pressure on constrained CI hosts.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from jasnell September 27, 2026 07:02
@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 27, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 27, 2026
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (cd908df) to head (eb7dc16).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66338      +/-   ##
==========================================
- Coverage   90.37%   90.36%   -0.02%     
==========================================
  Files         792      792              
  Lines      275324   275324              
  Branches    52764    52757       -7     
==========================================
- Hits       248828   248789      -39     
- Misses      16918    16972      +54     
+ Partials     9578     9563      -15     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 27, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants