Conversation
ac40a0b to
051a79e
Compare
|
As you commented in #2550 (comment), Node.js is now building The PR nodejs/node#63737 to document this officially as Tier 2 supported is however still pending. Are you going to continue to work on this PR or a follow-on PR to pick up the official |
|
@MikeMcC399 feel free if you want to take a cut at this. You don't even need to use anything from this PR. I'll try and get back to it, but I haven't come back to this since I opened the draft |
|
I'll take a look again next week. It was mid August when I looked at a possible solution previously so I've already lost my train of thought, and I'll need to refresh my memory before continuing 🙂 ! I haven't compared your proposal with mine at this stage, but I did also address documentation, not just the scripts. |
6a773d6 to
2bbd3c5
Compare
2bbd3c5 to
1508029
Compare
|
@MikeMcC399 I kind of got it working, but I think the v26 issue might be a real runtime thing. I believe it might have been fixed in the unofficial at some point |
Node.js official builds starting with Node.js 25.0.0 are built with This is a difference compared to the unofficial musl builds. There is an additional prerequisite It needs The prerequisites for Node.js 26 Alpine x64 are then:
|
| @@ -7,41 +7,45 @@ RUN addgroup -g 1000 node \ | |||
| && apk add --no-cache \ | |||
| libstdc++ \ | |||
There was a problem hiding this comment.
| libstdc++ \ | |
| libatomic libstdc++ \ |
This needs adding to the generated Dockerfiles as well.
There was a problem hiding this comment.
If you want to push any changes and re-run update.sh feel free
There was a problem hiding this comment.
I'd probably put this on it's own line like the other apk add calls though
There was a problem hiding this comment.
I'd prefer to leave the changes to you for simplicity's sake. It would be nice to get this finished before Node.js 27 comes along, but otherwise there's no great urgency.
|
Would you check the PR title and description? The PR is now covering 22, 24 & 26 whereas the title refers to 24+. |
Description
Opening as a draft, as this is just a paper test right now.
Motivation and Context
There is still some work going on with v22 in the build repo, so this is a "step 1" to start using the official builds for musl for the newer releases.
Copied the setup from the Debian template for the steps grab and verify the artifcats. The fallback build is left for the ARM architecture and some old ones still included as part of v22.
Testing Details
Example Output(if appropriate)
Types of changes
Checklist