Repository navigation
test: reset the field separator in ExistsFilterTest - #1323
Conversation
NitriteConfig.fieldSeparator is static. NitriteConfigTest and NitriteBuilderTest leave it as "Separator" / "::", and when they run first (as on the Ubuntu runner) testEmbeddedField cannot resolve "address.city". This failed the build of every open PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe ChangesExists filter tests
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to This test-fixture change introduces no supported merge-blocking risk; production behavior is unchanged. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ExistsFilterTest.testEmbeddedFieldfails on the Ubuntu runner, which broke the build of #1320, #1321 and #1322.Cause:
NitriteConfig.fieldSeparatoris static.NitriteConfigTestandNitriteBuilderTestset it to"Separator"/"::"and never restore it; when they run beforeExistsFilterTest(as on Ubuntu),address.cityis not treated as an embedded path.Reproduced locally with
-Dtest=NitriteConfigTest,ExistsFilterTest -Dsurefire.runOrder=alphabetical; passes with the fix. The test now resets the separator in@Before, asDocumentTestdoes.🤖 Generated with Claude Code
Summary by CodeRabbit