Skip to content

constrain all deps #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshafer-NI wants to merge 1 commit into
base: main
Choose a base branch
from
Open

constrain all deps #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions pyproject.toml
View file
Open in desktop

@bkeryan bkeryan Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My predictions:

  • This will put ni-python-styleguide in the critical path of updating dependencies (e.g. click)
  • When a new version of one of these dependencies is released and a client has a direct dependency on it (e.g. click), Renovate will offer to downgrade ni-python-styleguide for clients to the version before this change 😅

@mshafer-NI mshafer-NI Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will put ni-python-styleguide in the critical path of updating dependencies (e.g. click)

This is a good point..., I need to think about this more.

@mshafer-NI mshafer-NI Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where I'm landing:

  • while a break in click means that updating to consume newer click will cause clients to fail linting; ultimately, the click dep should not be "managed" here.

So...

  • don't do this (as is)
  • do constrain critical / linting deps (flake8 + plugins)
  • leave "tooling" deps (click, toml, pathspec) alone

Thoughts?

@bkeryan bkeryan Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • do constrain critical / linting deps (flake8 + plugins)
  • leave "tooling" deps (click, toml, pathspec) alone

That sounds good to me.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ include = ["ni_python_styleguide/config.toml"]

[tool.poetry.dependencies]
python = "^3.9"
pathspec = ">=0.11.1"
pathspec = ">=0.11.1,<2.0"

# Tools we aggregate
flake8 = [
Expand All @@ -34,16 +34,16 @@ better-diff = "^0.1.3"

# Additional support libraries
# These dependencies were selected because they are already used by black.
click = ">=7.1.2"
toml = ">=0.10.1"
isort = ">=5.10"
click = ">=7.1.2,<9.0"
toml = ">=0.10.1,<0.11"
isort = ">=5.10,<10.0"

# flake8 plugins should be listed here (in alphabetical order)
flake8-black = ">=0.2.1"
flake8-docstrings = ">=1.5.0"
flake8-import-order = "^0.19.2"
flake8-tidy-imports = ">=4.11.0"
pep8-naming = ">=0.11.1"
flake8-black = ">=0.2.1,<0.5"
flake8-docstrings = ">=1.5.0,<2.0"
flake8-import-order = ">=0.19.2,<0.20"
flake8-tidy-imports = ">=4.11.0,<5.0"
pep8-naming = ">=0.11.1,<0.16"

# Rejected flake8 plugins should be listed here (in alphabetical order)
# Also describe why it is rejected and/or add a link
Expand Down
Loading