Repository navigation
Conversation
Signed-off-by: Shrish Kulkarni <shrish.kulkarni@ni.com>
shrishsk
marked this pull request as draft
October 17, 2026 12:32
Signed-off-by: Shrish Kulkarni <shrish.kulkarni@ni.com>
shrishsk
marked this pull request as ready for review
October 17, 2026 14:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.No client-facing behavior changes.I've added tests applicable for this pull request.No permanent unit or system tests added for this CI configuration change; validated locally using temporary breaking-change probes.What does this Pull Request accomplish?
Adds automated public API compatibility checks to the PR workflow using Griffe.
The job uses read-only permissions, pinned actions, and Griffe 2.3.2. It requires no NI-DAQmx driver or package runtime dependencies.
Fixes #914.
Why should this Pull Request be merged?
Detects potential API-breaking changes before merging, rather than relying solely on internal tests after merge.
Checking documented implementation modules explicitly closes a verified coverage gap: checking
nidaqmx.systemalone did not detect removal of a documented collection property.What testing has been done?
DeviceCollection.device_names; the expanded workflow command emitted a GitHub annotation and exited with code1.poetry run ni-python-styleguide lintpassed.poetry run mypypassed across 272 source files.npx cspell "**" --no-progresspassed across 429 files.Temporary validation scripts, task configuration, and API modifications were removed. Hardware-dependent regression tests were not run.