Repository navigation
Conversation
Signed-off-by: Shrish Kulkarni <shrish.kulkarni@ni.com>
zhindes
approved these changes
Oct 16, 2026
Collaborator
|
Let's make sure @bkeryan reviews as well :) |
bkeryan
requested changes
Oct 16, 2026
bkeryan
reviewed
Oct 16, 2026
bkeryan
reviewed
Oct 16, 2026
added 3 commits
October 16, 2026 22:57
Signed-off-by: Shrish Kulkarni <shrish.kulkarni@ni.com>
Signed-off-by: Shrish Kulkarni <shrish.kulkarni@ni.com>
This reverts commit 2e0ed48.
Author
|
@bkeryan Thanks for the feedback. I moved the metadata below each docstring, updated the changelog, and revised the PR description to follow the project template and accurately reflect validation. |
bkeryan
requested changes
Oct 16, 2026
Co-authored-by: Brad Keryan <brad.keryan@emerson.com>
Signed-off-by: Shrish Kulkarni <shrish.kulkarni@ni.com>
Author
|
@bkeryan Thanks for the suggestion. I added the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Adds PEP 723 dependency metadata after the module docstring in all 53 Python examples. Each script declares its directly imported third-party packages, including
numpy,nitypes,matplotlib, andnptdmswhere applicable.Closes #1030.
Why should this Pull Request be merged?
PEP 723-aware script runners can use the metadata to install the dependencies needed by each example, making the examples easier to run. Keeping the docstring first makes each example’s purpose immediately visible.
What testing has been done?
uv export --scriptparsed and resolved dependencies for all 53 scripts.pipx run --pathon four examples importingmatplotlibornptdms. Dependency installation succeeded, but execution stopped at DAQmx calls because NI-DAQmx is not installed in the test environment.git diff --checkpassed.