Skip to content

Add minimum version for certifi #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joverlee521 merged 2 commits into from
Oct 22, 2026
+17 −1
Merged

Add minimum version for certifi #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fceb36
Add minimum version for certifi
joverlee521 Oct 21, 2026
2ef2f1b
devel/setup-venv: Ensure we are using pip 26.2.2
joverlee521 Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ development source code and as such may not be routinely kept up to date.

# __NEXT__

## Development

* Set minimum version requirement for certifi to 2026.10.19 in response to
[CA certificate compromise incident](https://discuss.python.org/t/information-for-python-users-regarding-emudhra-emsign-ca-certificate-security-incident/109576).
([#549](https://github.com/nextstrain/cli/pull/549))

# 11.1.0 (15 October 2026)

Expand Down
3 changes: 3 additions & 0 deletions devel/setup-venv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,8 @@ venv="$base/.venv"
set -x
rm -rf "$venv"
python3 -m venv "$venv"
# Ensure that we are securely upgrading pip to 26.2.2
# <https://discuss.python.org/t/information-for-python-users-regarding-emudhra-emsign-ca-certificate-security-incident/109576>
"$venv"/bin/pip install "pip @ https://files.pythonhosted.org/packages/3f/06/3e4420302363fbb71be3c7f35ce042f54bfca330e3e66b3a2e3c4cca579f/pip-26.2.2-py3-none-any.whl#sha256=fd7f4dfa8190e014013b9f08f3e973f4e4c26ffd179a204895533a7254813a70"

@victorlin victorlin Oct 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to have now, but we'll probably want to drop it after some time, once the compromised certificates are globally dead in practice.

"$venv"/bin/pip install --upgrade pip setuptools wheel pip-tools
"$venv"/bin/pip install -e '.[dev]'
6 changes: 6 additions & 0 deletions doc/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ development source code and as such may not be routinely kept up to date.
(v-next)=
## __NEXT__

(v-next-development)=
### Development

* Set minimum version requirement for certifi to 2026.10.19 in response to
[CA certificate compromise incident](https://discuss.python.org/t/information-for-python-users-regarding-emudhra-emsign-ca-certificate-security-incident/109576).
([#549](https://github.com/nextstrain/cli/pull/549))

(v11-1-0)=
## 11.1.0 (15 October 2026)
Expand Down
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ def find_namespaced_packages(namespace):
python_requires = '>=3.10',

install_requires = [
"certifi",
# Minimum version of certifi for CA certificate incident
# <https://discuss.python.org/t/information-for-python-users-regarding-emudhra-emsign-ca-certificate-security-incident/109576>
"certifi >=2026.10.19",
"docutils",
"fasteners",
"importlib_resources >=5.3.0; python_version < '3.11'",
Expand Down
Loading