Repository navigation
fix: adapt llama-server to current xllamacpp binding - #307
Merged
Merged
Conversation
xllamacpp 2026.10.11549 renames CommonParams.hostname to hostnames (now a list) and drops use_mmap/use_mlock, so the setattr loop crashed at startup and took down every consumer CI. SERVER_KEYS updated, the config sends hostnames as a list, and keys the binding no longer knows are skipped with a warning instead of killing the server. Verified against 2026.10.11549: server boots on a known-good model and serves /health and /v1/chat/completions; unknown keys log and continue. Assisted-by: opencode:zai/glm-5.3 Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
1 task done
marcelklehr
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xllamacpp
2026.10.11549renamesCommonParams.hostnametohostnames(now a list) and dropsuse_mmapanduse_mlock, so the setattr loop in llama_server crashed at startup and took down consumers' CI.SERVER_KEYSnow sendshostnamesas a list, the dropped keys are removed, and keys the binding no longer knows are skipped with a warning, so the next rename degrades to a log line instead of a dead server.Verified on
2026.10.11549with a cpu wheel: llama-server boots on a small test model and serves/healthand/v1/chat/completions, and a config still carrying the old keys starts fine. On the locked2026.9.10809the unknown key is skipped with the warning and the default bind still serves the health check.Closes #306
🤖 AI (if applicable)