Skip to content

fix(files): Make sure webdav failures raise an error - #282

Merged
marcelklehr merged 1 commit into
mainfrom
fix/webdav-status-checks
Oct 21, 2026
Merged

marcelklehr merged 1 commit into
mainfrom
fix/webdav-status-checks

Conversation

@marcelklehr

Copy link
Copy Markdown
Member

fixes #242

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

fixes #242

Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

@WSHAPER WSHAPER left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if a missing file in get_file_content might kill the task instead of letting the agent recover, please check. Looking forward to a response.

@kyteinsky

Copy link
Copy Markdown
Contributor

Not sure if a missing file in get_file_content might kill the task instead of letting the agent recover, please check. Looking forward to a response.

Instead of the 404 as the result of the task, the agent receives the error structured as an error. The exception is caught when the tool call is made and a stringified error is returned I believe, then the turns continue, the LLM might call a new tool or output a message for the user.
It would not break the loop.

@marcelklehr
marcelklehr merged commit 075bf4e into main Oct 21, 2026
7 checks passed
@marcelklehr
marcelklehr deleted the fix/webdav-status-checks branch October 21, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File tools (upload/create folder/move/copy/delete) always report success, even when the WebDAV request fails

3 participants