Repository navigation
Jglweb 1832 cke5 plugin fixes - #134
Merged
Merged
Conversation
…r data - add copyLocationsOnLoad option: loaded elements switch to a copy of their location before they can be edited - never delete locations from the editor: undo, paste and drag and drop can bring removed elements back - send source when updating a location, so it is kept after the first edit - run location requests of one element one after another, update targets the location created before it - report failed location requests through the onError option, revert the selection when creating fails - keep stored CSS class and variation when data is saved before the selected image is loaded - export waitForLocationRequests() and hasPendingLocationRequests() for integrations
RandyCupic
requested changes
Nov 19, 2026
RandyCupic
left a comment
Member
There was a problem hiding this comment.
Tested together with remote-media-ibexa#7 on Ibexa 4.6. Copy on load works: a draft no longer touches the published version, the overrides carry over to the copy and source stays after an update. The error handling and keeping cssClass and the variation before the load returns look good too. Nice work.
One thing before merge: locations have to be deleted again, no orphans. See inline.
No CI ran on this PR, please re-run it.
Member
|
This goes out as 3.2.0, it adds new plugin options. Please rename the changelog section. |
…delete unused locations on save - copyLocationsOnLoad is replaced by copyLocationsOnChange: stored locations are copied on the first change of an element instead of when the editor loads, opening the editor creates nothing - locations the editor created or copied (and, without copyLocationsOnChange, the stored locations it loaded) are deleted on submit of the form containing the editor when no editor on the page references them anymore, with keepalive requests - deleteUnusedLocations() export for integrations which save the editor data otherwise, deleteLocation endpoint option restored - the copy error translation is removed, a failed copy reports the update error - changelog section renamed to 3.2.0
- getUnusedStoredLocations(form) returns, with copyLocationsOnChange, the stored locations the editors loaded which no editor on the page references anymore, for integrations to send with the saved data so the server deletes those nothing else references - deleteUnusedLocations() takes the form to clean instead of a list of editors
Member
Author
|
@RandyCupic should be fixed now |
RandyCupic
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from comments on netgen/remote-media-ibexa#7 that were related to core plugin functionalities