Repository navigation
Raise platform requirements for 4.0 - #125
Open
RandyCupic wants to merge 15 commits into
Open
RandyCupic wants to merge 15 commits into
RandyCupic wants to merge 15 commits into
Conversation
Implement upload-limited multi-resource handling with multi-select and reorderable gallery cards, split RemoteMediaType into single and collection form types, convert the multi-gallery components to props-down/events-up data flow, and improve the multi-upload UX, i18n and wire format. Add a Norwegian Bokmål (nb) translation file. Fix the CKEditor "Manage Media" modal so the gallery renders in collection mode (default the embed to single-select and guard the missing multi-select translation key that was blanking the gallery). Includes rebuilt NGRM frontend assets (remotemedia.js + remotemedia.css).
Clearing a gallery now sticks, folder placeholders no longer create Cloudinary folders and existing CKEditor embeds load their media. Malformed payloads fail the form instead of emptying the collection.
Browsing or uploading into a gallery now skips resources that are already in it and stops at the upload limit, and replacing a single image keeps its watermark.
…mote The metadata is still saved locally, and the warning names the remote id so missing assets can be found.
Import order and missing function imports, no short ternary in the collection transformer, and intersection-typed provider mocks in the form type tests.
The multi-upload rewrite dropped the always-present remoteId input, so removing the media from a single field sent nothing and forms that keep the previous value on a missing field could not clear it. Dist rebuilt with Node 12.
mivancic
force-pushed
the
multiupload
branch
from
November 16, 2026 08:55
6ea30c7 to
3b7dc1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the 4.0 platform requirements on top of the multi-upload branch (#124).
symfony/proxy-manager-bridge. Nothing used it, and it has no Symfony 7 release.ezpublish-legacy-dircomposer extra.The lower bound is PHP 8.3 + Symfony 5.4 because Akeneo 2026 pins
php 8.3.*and Symfony 5.4. The lowest-deps job installs the same set Akeneo uses: ORM 2.20.0, DBAL 2.13, doctrine-bundle 2.7, Symfony 5.4.0. The plan is to raise the floor to PHP 8.4 + Symfony 7.4 in a later 4.x minor, once Akeneo supports it.Akeneo note: Cloudinary SDK 3 requires
psr/log ^2|^3, but Akeneo pinselasticsearch/elasticsearch 7.11.0, which requirespsr/log ~1.0. To install 4.0, the Akeneo project needs"elasticsearch/elasticsearch": "7.17.3 as 7.11.0"in its root composer.json. This was verified with a composer dry-run against the project lock file.Code changes needed for the new platform:
mixedparameter and return types, as required by Symfony 7+.rateLimitResetAtisint|falsein SDK 3).EntityRepository), Cloudinary SDK 3 (ApiResponsereturn values) and Symfony 8 (Application::addCommand()).CI:
masterand on everyX.Ybranch.^8.0constraint still covers 8.1.Tested locally on PHP 8.4. Tests (641) pass on Symfony 5.4 (normal and lowest), 7.4 and 8.1. PHPStan and CS are clean.
Known gap: the
array/objectcolumn types in the Doctrine mappings no longer exist in DBAL 4. An application on DBAL 4 will fail when it loads the mapping, even though the tests pass. This is handled separately by converting those columns to JSON.