Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sources-regeneration step in
build_linux.ymlandbuild_windows.ymlnow always regenerates and goes red when the result differs from the committedsrc.zserioruns with-ignoreTimestamps: without it zserio skips writing files that look newer thantutorial.zs, so the step could pass without regenerating anythinggit add --intent-to-add src+git diff --exit-code -- srcfails the step on any change, including a generated file that is not committedkeepalivejob (liskin/gh-workflow-keepalive@v1, added in1e0639b), which re-enables the workflow it runs inVerified:
gh run viewof the latest scheduled runs, Linux30725731727and Windows37166081740→keepalivesuccess in both;gh api .../actions/workflows→ bothactivebash -eo pipefailin a clone: clean tree → exit 0; a committed file with an extra line → exit 1; a generated file missing from the repo → exit 1-ignoreTimestamps: the edited file → exit 0 (zserio skipped regeneration), which is why the flag is injavac,Main write_joe/read/write_boss/read) → exit 0build_linuxpass (run37275727859),build_windowspass (run37275727854, log shows the regeneration andgit diff --exit-coderan)2 files changed, 6 insertions(+), 2 deletions(-)Not verified: the red path on the Windows runner (only shown locally on macOS); a scheduled run of the changed workflows. No
verify.shor test suite exists in this repo.Closes #2