Repository navigation
Add specialisation pragmas for hot polymorphic paths. - #860
Merged
Merged
Conversation
For hadrian (ghcs build system) these improve runtime of a no-rebuild invocation of the build system by about 10%.
Owner
|
These seem harmless at worst, and if they get a big perf increase, well worth having. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For hadrian (ghcs build system) these improve runtime of a no-rebuild invocation of the build system by about 10%.
I have not spent much time verifying all of the pragmas are needed, only that the speedup happens as they are. Build time overhead is about 1% from the pragmas.
The other alternative would be to use
-fspecialise-aggressively -fexpose-overloaded-unfoldings, which is more robust but comes at a heavier build time cost.