Repository navigation
fix(native): measure inline-size and block-size container queries - #480
Open
YevheniiKotyrlo wants to merge 1 commit into
Open
YevheniiKotyrlo wants to merge 1 commit into
YevheniiKotyrlo wants to merge 1 commit into
Conversation
getContainerFeatureValue answered undefined for both logical size features, so @container (min-inline-size: 400px) matched nothing at any size, on the axis container-type: inline-size names. React Native lays out in one writing mode, so the inline axis is the width and the block axis the height.
Contributor
Author
YevheniiKotyrlo
marked this pull request as ready for review
October 11, 2026 17:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
On
main,getContainerFeatureValueanswersundefinedforinline-sizeandblock-size, so@container (min-inline-size: 400px)matches nothing at any size, thoughinline-sizeis the axiscontainer-type: inline-sizenames.Solution
React Native lays out in one writing mode, so the inline axis is the width and the block axis is the height.
Tests
src/__tests__/native/container-logical-sizes.test.tsxchecksmin-inline-sizeandmin-block-sizeat 39, 40 and 41px on a non-square container, the waycontainer-boundaries.test.tsxchecks width and height. Both cases fail onmain.Verification
Every
ci.ymljob but the iOS build, on Ubuntu with Node 22.18.0: green, withyarn testat 1337 passed.Split out of #425.
Device evidence, before and after: #480 (comment)