Skip to content

fixt: vulnerability list - #819

Draft
ybelMekk wants to merge 2 commits into
mainfrom
vuln/list
Draft

ybelMekk wants to merge 2 commits into
mainfrom
vuln/list

Conversation

@ybelMekk

Copy link
Copy Markdown
Contributor

No description provided.

@ybelMekk
ybelMekk requested a balanced review from Copilot October 24, 2026 14:09
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

📝 Changelog preview

Below is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog.

v7.1.0 - 2026-10-24

Full Changelog: v7.0.3...v7.1.0

🚀 Features

  • (vulnerability) List workload findings and priorities (7d1f250)

⚙️ Miscellaneous Changes

  • (vulnerability) Add completion tests for list command (49cf70c)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Serial per-image GraphQL requests substantially increase listing latency for teams with distinct workload images.

1 open issue
What changed in this PR

This PR expands vulnerability listings in the Nais CLI with paginated results, operational priority filters, and richer risk and remediation details.

Changes:

  • Adds pagination for workload summaries, workloads, and image vulnerabilities.
  • Adds priority and KEV filters, tenant-wide summaries, and expanded table and JSON output.
  • Adds tests for pagination, priority validation, and shell completion.
File Description
internal/​vulnerability/​vulnerability.go Adds paginated queries, tenant-wide summaries, and richer vulnerability data.
internal/​vulnerability/​list_test.go Tests pagination, cursor validation, and team preservation.
internal/​vulnerability/​command/​list.go Connects filters and tenant-wide listing to expanded CLI output.
internal/​vulnerability/​command/​flag/​flag.go Defines new filters and priority validation and completion.
internal/​vulnerability/​command/​flag/​flag_test.go Tests accepted and rejected priority values.
internal/​vulnerability/​command/​completion_test.go Tests listing subcommands and flag completion.

Review effort: Balanced

imageID := workload.GetImage().Id
entries, ok := images[imageID]
if !ok {
entries, err = listImageCVEs(ctx, client, imageID, vulnerabilityFilter)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants