Skip to content

fix: reject FSS environments when creating cloud resources - #808

Merged
frodesundby merged 1 commit into
mainfrom
fix/cloud-resource-fss-environments
Oct 22, 2026
Merged

frodesundby merged 1 commit into
mainfrom
fix/cloud-resource-fss-environments

Conversation

@frodesundby

Copy link
Copy Markdown
Contributor

Exclude on-premises FSS environments from Postgres creation choices and reject explicit or configured FSS environments for Postgres, Valkey, and OpenSearch creation. Previously, creation accepted all environments without checking on-premises support.

Exclude on-premises FSS environments from Postgres creation choices and reject explicit or configured FSS environments for Postgres, Valkey, and OpenSearch creation. Previously, creation accepted all environments without checking on-premises support.
@github-actions

Copy link
Copy Markdown
Contributor

📝 Changelog preview

Below is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog.

v7.0.1 - 2026-10-22

Full Changelog: v7.0.0...v7.0.1

🐛 Bug Fixes

  • Reject FSS environments when creating cloud resources (148c097)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking defects in these focused changes, and regression coverage matches the intended behavior, though tests were not executed.

No open issues 🎉

What changed in this PR

Prevents unsupported cloud-resource creation in on-premises FSS environments while preserving supported environments and explicit configuration overrides.

Changes:

  • Adds shared detection of environment names ending in -fss.
  • Filters FSS environments from Postgres creation choices and rejects them during Postgres, Valkey, and OpenSearch creation.
  • Adds regression tests for filtering, validation, and environment configuration precedence.
File Description
internal/​valkey/​command/​flag/​flag.go Rejects FSS environments during create validation.
internal/​postgres/​command/​instance_create_environment_test.go Tests filtered choices and explicit or configured FSS rejection.
internal/​postgres/​command/​environment.go Filters creation choices and rejects provided FSS environments.
internal/​opensearch/​command/​flag/​flag.go Rejects FSS environments during create validation.
internal/​flags/​environment.go Adds the shared IsOnPrem suffix check.
internal/​flags/​environment_test.go Tests FSS detection and supported names.
internal/​application/​create_environment_test.go Tests Valkey and OpenSearch validation and configuration precedence.

Review effort: Balanced

@frodesundby
frodesundby merged commit 44c28bc into main Oct 22, 2026
23 checks passed
@frodesundby
frodesundby deleted the fix/cloud-resource-fss-environments branch October 22, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants