Repository navigation
fix: reject FSS environments when creating cloud resources - #808
Merged
Merged
Conversation
Exclude on-premises FSS environments from Postgres creation choices and reject explicit or configured FSS environments for Postgres, Valkey, and OpenSearch creation. Previously, creation accepted all environments without checking on-premises support.
Contributor
📝 Changelog previewBelow is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog. v7.0.1 - 2026-10-22Full Changelog: v7.0.0...v7.0.1 🐛 Bug Fixes
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking defects in these focused changes, and regression coverage matches the intended behavior, though tests were not executed.
No open issues 🎉
What changed in this PR
Prevents unsupported cloud-resource creation in on-premises FSS environments while preserving supported environments and explicit configuration overrides.
Changes:
- Adds shared detection of environment names ending in
-fss. - Filters FSS environments from Postgres creation choices and rejects them during Postgres, Valkey, and OpenSearch creation.
- Adds regression tests for filtering, validation, and environment configuration precedence.
| File | Description |
|---|---|
internal/valkey/command/flag/flag.go |
Rejects FSS environments during create validation. |
internal/postgres/command/instance_create_environment_test.go |
Tests filtered choices and explicit or configured FSS rejection. |
internal/postgres/command/environment.go |
Filters creation choices and rejects provided FSS environments. |
internal/opensearch/command/flag/flag.go |
Rejects FSS environments during create validation. |
internal/flags/environment.go |
Adds the shared IsOnPrem suffix check. |
internal/flags/environment_test.go |
Tests FSS detection and supported names. |
internal/application/create_environment_test.go |
Tests Valkey and OpenSearch validation and configuration precedence. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude on-premises FSS environments from Postgres creation choices and reject explicit or configured FSS environments for Postgres, Valkey, and OpenSearch creation. Previously, creation accepted all environments without checking on-premises support.