[RomanPudashkin]

Ports (framework changes): musescore/MuseScore#35231

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: musescore/muse_framework/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 158bf5fd-6248-4605-98a8-406a25c46bdc

📥 Commits

Reviewing files that changed from the base of the PR and between 3cae2ca and 9747192.

📒 Files selected for processing: 13

• framework/interactive/iinteractive.h
• framework/interactive/internal/interactive.cpp
• framework/interactive/qml/Muse/Interactive/StandardDialog.qml
• framework/interactive/qml/Muse/Interactive/StandardDialogPanel.qml
• framework/musesampler/imusesamplerinfo.h
• framework/musesampler/internal/apitypes.h
• framework/musesampler/internal/libhandler.h
• framework/musesampler/internal/musesampleractioncontroller.cpp
• framework/musesampler/internal/musesampleractioncontroller.h
• framework/musesampler/internal/musesamplerresolver.cpp
• framework/musesampler/internal/musesamplerresolver.h
• framework/musesampler/tests/mocks/musesamplerconfigurationmock.h
• framework/musesampler/tests/mocks/musesamplerinfomock.h

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Interactive button data now includes icons, and the dialog panel applies them to custom buttons. The asynchronous rejection path constructs a Cancel result without explicitly setting showAgain to false. MuseSampler initialization supports typed results for newer APIs and legacy results for older APIs. The resolver records initialization failures, and the controller reports them. The changes also add mocks for MuseSampler configuration and information interfaces.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 97471

No actionable issue remains from this review; the change is ready for normal merge checks.

Pre-merge checks: 3 · 2

Failed checks: 2 warnings

Check name	Status	Explanation	Resolution
Description check		The description contains only a link to a related MuseScore pull request. It does not include the required issue reference, change motivation, checklist responses, testing details, or build configurat…	Complete the repository template. Add a Resolves issue reference, a short change and motivation summary, accurate checklist selections, testing information, AI-assistance details if applicable, and the required build configuration.
Docstring Coverage		Docstring coverage is 8.70% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 23 functions across 11 files. (2 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly describes the primary change: reporting MuseSampler initialization failures through IMuseSamplerInfo.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description contains only a link to a related MuseScore pull request. It does not include the required issue reference, change motivation, checklist responses, testing details, or build configuration.

Resolution

Complete the repository template. Add a Resolves issue reference, a short change and motivation summary, accurate checklist selections, testing information, AI-assistance details if applicable, and the required build configuration.

Full details: Docstring Coverage

Explanation

Docstring coverage is 8.70% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 23 functions across 11 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}