Repository navigation
Fix fixed-size arrays in typed map entries - #759
liuzicheng1987 merged 1 commit into
Conversation
|
That covers all the major performance issues I found while porting my project’s serialization to reflect-cpp, so I don’t expect to submit any more major changes in the near future. Could you also publish a minor release so I can switch my project to a released version? |
|
@Altren, OK. There is one more thing I have to do before I can do a release, though. I promised the vcpkg-people that I would fix some issues related to enchantum. But I will take care of it over the next couple of days. |
|
@Altren thank you for these contributions. |
b2fc5ac
into
munich-data-engineering:main
Great. Thank you |
Fixed-size array values in typed maps fail to compile because
Parent::add_fixed_arraydoes not handleMapEntry. This breaks Boost.Serialization and Cereal CI when #755 and #756 are combined, and also affects YAS.Handle fixed arrays in typed map entries for Boost.Serialization, Cereal, and YAS while preserving the omitted array-length prefix. Add regression coverage for numeric map keys, empty array values, and serialized sizes, and document the writer hook.
@liuzicheng1987 Sorry, the interaction between my PRs caused CI failures on main. This PR fixes those failures, so it’s important to merge it soon.