Repository navigation
fix(git): synthesize diff line sigils in patches - #343
Open
linbingquan wants to merge 2 commits into
Open
linbingquan wants to merge 2 commits into
linbingquan wants to merge 2 commits into
Conversation
`git2`'s `DiffLine::content()` omits the `+`/`-`/space origin prefix, so generated patches were missing line markers. Add a `write_diff_line` helper that prepends the appropriate sigil for content lines while leaving file headers, hunk headers, binary notices, and EOF markers untouched, and use it for staged, unstaged, and branch-to-branch diffs. Add unit tests covering content lines, headers, binary notices, and `\ No newline at end of file` markers.
linbingquan
changed the title
ODAncona
requested changes
Oct 19, 2026
ODAncona
left a comment
ODAncona
left a comment
Collaborator
There was a problem hiding this comment.
The test should be in a separate file.
Author
|
Thanks for the suggestion. I moved the If the PR has any problem, please tell me. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says.