Skip to content

Convert SummaryPanel and ActionBar to functional components - #9635

Open
camd wants to merge 1 commit into
masterfrom
camd/functional-summary-actionbar
Open

camd wants to merge 1 commit into
masterfrom
camd/functional-summary-actionbar

Conversation

@camd

@camd camd commented Jun 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Converts the SummaryPanel and ActionBar class components in the job-view details panel to functional components with hooks. This is a pure refactor with no behavior change.

  • SummaryPanel becomes a memoized function component.
  • ActionBar moves its lifecycle window-event listeners (openLogviewer, openRawLog, openGeckoProfile, jobRetrigger) into a useEffect, and reads decisionTaskMap directly from the pushes store, so the class-to-store wrapper is no longer needed. The named export is now the function itself; the default export remains a memoized wrapper for compatibility.

Notes

This PR is now independent of the expired-task handling work (previously stacked on camd/expired-jobs-details-panel). It targets master directly so it can be merged on its own. The two changes touch overlapping regions of ActionBar.jsx/SummaryPanel.jsx, so a small merge conflict is expected when the second of the two lands — but either can go first.

@codecov-commenter

codecov-commenter commented Jun 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.02941% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.18%. Comparing base (f7dfd76) to head (6200a4b).

Files with missing lines Patch % Lines
ui/job-view/details/summary/ActionBar.jsx 55.04% 49 Missing ⚠️
ui/job-view/details/summary/SummaryPanel.jsx 85.18% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9635      +/-   ##
==========================================
+ Coverage   84.17%   84.18%   +0.01%     
==========================================
  Files         648      648              
  Lines       39665    39641      -24     
  Branches     3542     3530      -12     
==========================================
- Hits        33387    33373      -14     
- Misses       5891     6122     +231     
+ Partials      387      146     -241     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camd
camd force-pushed the camd/expired-jobs-details-panel branch from 65a4570 to d4d7afc Compare June 22, 2026 16:32
@camd camd self-assigned this Jun 27, 2026
@camd camd added the front-end label Jun 27, 2026
@camd
camd force-pushed the camd/functional-summary-actionbar branch from a88953c to 2b7905c Compare June 27, 2026 18:58
@camd
camd requested review from a team, beatrice-acasandrei and esanuandra as code owners June 27, 2026 18:58
@camd
camd changed the base branch from camd/expired-jobs-details-panel to master June 27, 2026 18:58
@camd
camd force-pushed the camd/functional-summary-actionbar branch 2 times, most recently from 993b26f to a7da60f Compare July 3, 2026 23:43
@camd
camd force-pushed the camd/functional-summary-actionbar branch from a7da60f to e19fdb9 Compare July 18, 2026 17:21
@camd
camd force-pushed the camd/functional-summary-actionbar branch from e19fdb9 to bf13cc8 Compare July 31, 2026 17:52
@netlify

netlify Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for treeherder ready!

Name Link
🔨 Latest commit 700d585
🔍 Latest deploy log https://app.netlify.com/projects/treeherder/deploys/6ad79c1d7eb5f011a2c008ef
😎 Deploy Preview https://deploy-preview-9635--treeherder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@camd
camd force-pushed the camd/functional-summary-actionbar branch 2 times, most recently from 3a193c2 to 71c1c80 Compare August 16, 2026 03:30
@camd
camd force-pushed the camd/functional-summary-actionbar branch 2 times, most recently from 661294d to a1b56fb Compare August 29, 2026 20:00
@camd
camd force-pushed the camd/functional-summary-actionbar branch 2 times, most recently from affc620 to 871c956 Compare September 11, 2026 20:25
@camd
camd force-pushed the camd/functional-summary-actionbar branch 3 times, most recently from ea3f0fb to 350a658 Compare September 22, 2026 16:43
@camd
camd force-pushed the camd/functional-summary-actionbar branch 3 times, most recently from 6796af1 to e15fc5d Compare October 6, 2026 17:23
@camd
camd force-pushed the camd/functional-summary-actionbar branch 2 times, most recently from 6200a4b to 54e7898 Compare October 11, 2026 18:01
@camd
camd force-pushed the camd/functional-summary-actionbar branch from 54e7898 to 27d6e7c Compare October 13, 2026 16:11
Convert the SummaryPanel and ActionBar class components to functional
components with hooks:

- SummaryPanel becomes a memoized function component.
- ActionBar moves its lifecycle window-event listeners into a useEffect
  and reads decisionTaskMap directly from the pushes store, so the class
  wrapper is no longer needed. Its export becomes the function itself
  (the default export remains a memoized wrapper for compatibility).

No behavior change.
@camd
camd force-pushed the camd/functional-summary-actionbar branch from 27d6e7c to 700d585 Compare October 20, 2026 16:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants