Skip to content

fix: let consumers choose the release log level - #5

Merged
kixelated merged 2 commits into
mainfrom
fix/upstream-log-filter
Nov 4, 2026
Merged

kixelated merged 2 commits into
mainfrom
fix/upstream-log-filter

Conversation

@kixelated

@kixelated kixelated commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The inherited log/release_max_level_debug feature prevents an application from choosing another release log level: Cargo feature unification fails with multiple release_max_level_* features set.

Approach

Port chromeos/cros-codecs@a050c6cd, and check compatibility with a consumer's log/release_max_level_trace in just ci.

README now records the audit of all five cros-libva commits through 59384456 and the one cros-codecs commit through a050c6cd, against the recorded Discord baselines. It also corrects the stale link-time libva description to match the existing loader.

All four ChromeOS/Discord repository advisory endpoints and global Rust advisory queries for both package names returned no published advisories on 2026-10-31.

Impact

  • Public Rust API and wire formats: unchanged.
  • Release log filtering belongs to the application; this library no longer selects a compile-time ceiling.
  • No version bump or crate publication.

Alternatives

Explicit image lifetimes, packed headers, and libva 2.23 VP9 build compatibility are already covered. Keep the owned-buffer API; optional borrowed inputs and protected-content headers have no required correctness consumer here.

Checks

  • Reproduced the conflicting-feature compilation error before the change; the same command passes afterward.
  • quest gate nix develop --command just ci: passed with this repository's pinned Rust 1.96.0 dev shell, including lint/format checks, 31 library test cases, the new compilation check, and cargo-deny.
  • Hardware tests can return early without a usable VA-API driver; this report makes no GPU execution claim. Cargo-deny reports four existing unused-license-allowance warnings.

Review

Claude Code (claude-opus-5-5) reviewed head 7b013835f2fe69e60972c7ffb7ed8602ce8a633e locally on 2026-11-04 during /quest-unblock: no findings. Dropping log/release_max_level_debug leaves the release level to the application, the new cargo check --features log/release_max_level_trace guards feature unification, and the README now matches the existing libloading loader. The check.yml id-token: write follow-up was resolved by #6.

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 31, 2026 15:44
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review November 4, 2026 22:33
@kixelated
kixelated merged commit 09ff001 into main Nov 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant