Repository navigation
fix: let consumers choose the release log level - #5
Merged
Merged
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
This was referenced Oct 31, 2026
kixelated
marked this pull request as ready for review
November 4, 2026 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inherited
log/release_max_level_debugfeature prevents an application from choosing another release log level: Cargo feature unification fails withmultiple release_max_level_* features set.Approach
Port chromeos/cros-codecs@a050c6cd, and check compatibility with a consumer's
log/release_max_level_traceinjust ci.README now records the audit of all five cros-libva commits through 59384456 and the one cros-codecs commit through a050c6cd, against the recorded Discord baselines. It also corrects the stale link-time libva description to match the existing loader.
All four ChromeOS/Discord repository advisory endpoints and global Rust advisory queries for both package names returned no published advisories on 2026-10-31.
Impact
Alternatives
Explicit image lifetimes, packed headers, and libva 2.23 VP9 build compatibility are already covered. Keep the owned-buffer API; optional borrowed inputs and protected-content headers have no required correctness consumer here.
Checks
quest gate nix develop --command just ci: passed with this repository's pinned Rust 1.96.0 dev shell, including lint/format checks, 31 library test cases, the new compilation check, and cargo-deny.Review
Claude Code (claude-opus-5-5) reviewed head
7b013835f2fe69e60972c7ffb7ed8602ce8a633elocally on 2026-11-04 during /quest-unblock: no findings. Droppinglog/release_max_level_debugleaves the release level to the application, the newcargo check --features log/release_max_level_traceguards feature unification, and the README now matches the existinglibloadingloader. Thecheck.ymlid-token: writefollow-up was resolved by #6.(Written by Claude Opus 5.5)