Repository navigation
test: run the README processing example against PostgreSQL - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's
CreateChatUseCaseholds oneTransactionand oneInboxper request, as modern-di wires them, so everypostgres_retryattempt reuses the same session. The existing db-retry tests open a new session per attempt, so this shape wasn't covered.Two tests run a copy of the example against PostgreSQL:
SerializationError(SQLSTATE 40001, raised withRAISE ... USING ERRCODE). The retry goes through the sameTransactionand commits one marker and one business row. WithDB_RETRY_RETRIES_NUMBER=1the test fails, so it passes only because of the retry.Both passed on the first run, so the README stays as it is.