fix(client): allow ClientSessionGroup to connect servers with no components (#3578) - #3580
teddiesloco wants to merge 1 commit into
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3578. If a maintainer assigns you to #3578, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Description
Fixes #3578.
ClientSessionGroup._aggregate_componentspreviously contained an exit-stack deletion check:This caused two issues:
connect_with_session, the session was not registered in_session_exit_stacks, raisingKeyErrorwhen connecting a server with zero components.connect_to_server, deleting the session from_session_exit_stacksprevented a subsequentdisconnect_from_serverfrom closing the session's exit stack, leaking the underlying transport until group teardown.Servers without tools, prompts, or resources are valid under the MCP specification (e.g. servers providing only roots, sampling, or minimal utilities).
Changes
_aggregate_components.test_client_session_group_connect_empty_components_serververifying that a server with no components connects without error and disconnects cleanly.Testing
uv run pytest tests/client/test_session_group.pypassed (13 passed).uv run ruff checkanduv run ruff format --checkclean.