Repository navigation
Test that passages may share coordinates across levels - #154
Merged
Merged
Conversation
A validate_adventure check that compared positions without the level would refuse a passage landing on another level's cell with its own coordinates, or on a cell whose coordinates match a far cell on a different level. The fixture had neither case, so this test adds both and requires them to validate clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds one acceptance test to the passage contract (PR 153). A contract review found that the fixture can't catch a validate_adventure check that ignores the level: no passage lands on another level's cell with its own coordinates, and no destination shares coordinates with a far cell on a different level. The new test adds both cases and requires the document to validate clean. It's under the same xfail marker and passes today, because the checks don't exist yet.