Skip to content

Fix LibriSpeech model_fn return annotations - #929

Open
mrhimanshu wants to merge 1 commit into
mlcommons:devfrom
mrhimanshu:fix/librispeech-model-fn-return-type
Open

mrhimanshu wants to merge 1 commit into
mlcommons:devfrom
mrhimanshu:fix/librispeech-model-fn-return-type

Conversation

@mrhimanshu

Copy link
Copy Markdown

Summary

  • correct the PyTorch LibriSpeech Conformer model_fn annotation to describe its (logits, paddings) output
  • apply the same correction to the matching JAX implementation
  • add a focused regression test for both source contracts without importing the optional workload stacks

Validation

  • python -m pytest tests/test_model_fn_annotations.py -q (2 passed)
  • ruff format --check .
  • ruff check .
  • git diff --check

Fixes #762

@mrhimanshu
mrhimanshu requested a review from a team as a code owner October 17, 2026 10:49
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant