Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metal's
addmmcan lose precision prematurely during thealpha * (A @ B) + beta * Ccomputation.Currently, the GEMV and GEMVT kernels cast the accumulator and coefficients down to the output data type before applying scaling and bias. Similarly, the split-K output transform computes the scaled bias using output precision. For BF16 and FP16, these early conversions can cause incorrect rounding or avoidable overflow.
For example:
The current implementation returns
1.0. The corrected implementation returns the exactly representable result,1.0078125.This change:
gemv.hto the precompiled kernel's build dependencies.addmmbenchmark.Tested and validated on Apple M4 Pro.