Repository navigation
Clarify Runtime Events First Time filter and Duration behavior - #281
Merged
myronkaifung merged 9 commits intoOct 20, 2026
Merged
Conversation
Explain that a Runtime Event without a First Time filter behaves the same as First Time + Indefinitely, that End of Session serves the variant only in the client SDK session where the event first fires, that users are never re-bucketed into a different variant, and that "session" means the client SDK session. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NdJYJgVNYpsVXhD2sbPnsn
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
 [Low impact] The documentation changes appear safe to merge. Reviews (9) · Last reviewed commit: "Merge branch 'main' into claude/runtime-..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Greptile flagged that the "never re-bucketed" claim was too broad: control is always non-sticky and non-sticky assignments can change when variant splits or rollout % change. Scope the guarantee to sticky variants. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NdJYJgVNYpsVXhD2sbPnsn
Greptile flagged that "keeps it across sessions" conflated stickiness with the Duration setting: under End of Session the variant is not served in later sessions. Clarify that stickiness controls which variant (never a different one), while Duration controls whether it keeps being served. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NdJYJgVNYpsVXhD2sbPnsn
1. In After the Event - kept the original #2 so that it's not so complicated at the overview section This was what Claude updated: "2. The variant persists based on your duration setting: indefinitely (also the behavior when no First Time filter is set), or only for the client SDK session in which the event first fires (First Time + End of Session)" I reverted it to: 2. The variant persists based on your duration setting (session or indefinitely) 2. URL link to Feature Flag Concepts and Terminology was wrong by Claude, instead of /docs/featureflags#concepts--terminology it should be /docs/featureflags#concepts-&-terminology
Corrected the formatting of a link in the documentation regarding fallback values during feature flagging service downtime.
russell-loube-mixpanel
approved these changes
Oct 5, 2026
russell-loube-mixpanel
left a comment
russell-loube-mixpanel
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this @kurbycchua , lgtm
Contributor
|
…-first-time-clarification
kurbycchua
enabled auto-merge (squash)
October 20, 2026 06:08
myronkaifung
disabled auto-merge
October 20, 2026 23:50
myronkaifung
enabled auto-merge (squash)
October 20, 2026 23:50
myronkaifung
approved these changes
Oct 20, 2026
myronkaifung
disabled auto-merge
October 20, 2026 23:53
myronkaifung
deleted the
claude/runtime-events-first-time-clarification
branch
October 20, 2026 23:53
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Kurby Chua · Slack thread
Before: The Runtime Events page described the "First Time" filter's Duration options only as "Variant expires when the user's session ends" (End of Session) and "Variant persists in subsequent sessions" (Indefinitely). It never explained how a Runtime Event with no First Time filter differs from First Time + Indefinitely, whether a user could receive a different variant in a later session, or what "session" refers to.
After: The page now states that a Runtime Event without a First Time filter behaves the same as First Time + Indefinitely, spells out that End of Session serves the variant only in the client SDK session where the event first fires (and never again), clarifies that users are never re-bucketed into a different variant, and specifies that "session" means the client SDK session.
Clarifies documented behavior only; no product change.
How: Expanded the "(Optional) Add First Time Filter" step in
docs/featureflags/runtime-events.mdxwith precise Duration semantics and two clarifying<Note>callouts, and tightened the "After the Event" list. Behavior confirmed against the flags API and mixpanel-js source on 2026-09-30.🤖 Generated with Claude Code
https://claude.ai/code/session_01NdJYJgVNYpsVXhD2sbPnsn
Generated by Claude Code