Repository navigation
Preserve array shape and resolve callbacks before S7 access - #30
Merged
mitchelloharawild merged 4 commits intoOct 17, 2026
Merged
mitchelloharawild merged 4 commits into
mitchelloharawild merged 4 commits into
Conversation
mitchelloharawild
approved these changes
Oct 17, 2026
mitchelloharawild
left a comment
mitchelloharawild
left a comment
Owner
There was a problem hiding this comment.
Looks good, thanks for the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array replacement currently drops dimensions with development S7, and nested missing-value and vctrs operations can fail to find
.f.Update ranked indices in place so dimensions and dimension names survive replacement. Resolve the callback before reading the S7 property, preserving its evaluation context. Add a public array replacement regression for dimension names; existing array, predicate, and vctrs tests cover the reported failures.
Use S7’s load, unload, and build hooks when available, retaining
methods_register()for older releases. On development S7, unloading removes the package’s external S7 methods and dependency hooks, and the build hook cleans external generic bindings after method declarations.