Repository navigation
docs(login-plugin-integration): name the connect-spigot 0.15.16 login-stall line - #177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: the public contract page's packet-level paragraph ended at "the only thing that ends the stall is the
server's own login timeout". That is still true, but after
connect-java#175shipped in 0.15.16 theconnector now names that stall itself:
SpigotLoginStallWatchdog(handlerconnect_login_stall_watchdog),installed upstream of
connect_data_handler, emits one default-verbosity line ~10 s after the handshake whenthe login start never arrives. The published copy of this request is
connect.minekube.com/guide/login-plugin-integration;
the two copies are kept in step by this PR pair (minekube/connect carries the matching change to
.web/docs/guide/login-plugin-integration.mdplus thecheck-docs.mjspins).Change - docs-only, exactly one sentence, version-gated (
0.15.16 and newer):docs/login-plugin-integration.md: adds that sentence in the packet-level bullet, immediately after thecause-blind timeout it qualifies. It does not replace or weaken the existing text, and it keeps the honest
half: the line makes the stall visible, it does not end it and it does not complete the login.
No code, no config, no test, no version constant.
docs:prefix, so no release is cut by this merge.