Skip to content

Add MCP gallery as an independent customization feed - #337574

Draft
Paul (pwang347) wants to merge 72 commits into
pwang/marketplace-visibility-basefrom
pwang/mcp-gallery-customization-feed
Draft

Add MCP gallery as an independent customization feed#337574
Paul (pwang347) wants to merge 72 commits into
pwang/marketplace-visibility-basefrom
pwang/mcp-gallery-customization-feed

Conversation

@pwang347

@pwang347 Paul (pwang347) commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Add a default-on MCP Gallery source to Discover, independently of the default-on public GitHub Feed, behind the separate default-off chat.customizations.marketplace.enabled visibility experiment. Reuse the ranked, bounded, cancellable multi-source merger and opaque native gallery cursor without fabricating a score.
  • Keep public-feed queries in the desktop shared process while resolving gallery metadata in the renderer; map only display metadata and the exact registry name, never executable configuration.
  • Keep MCP installation provenance distinct: GitHub Feed uses a version-pinned feed registry record; MCP Gallery resolves the exact name through the configured VS Code registry. Both use existing canInstall/install policy. A same-name server from another registry does not substitute for the configured gallery item.
  • When enabled, move MCP discovery from the Chat Customizations MCP management page to Discover while retaining installed-server management and search. With the gate off, preserve the original Available section and gallery search. Update accessibility help and the manual test plan.

Activation and source ordering

  • Marketplace off: keep default and custom MCP galleries in the legacy MCP Available section.
  • Marketplace on, public feed off: show custom MCP galleries first, then the default MCP gallery in Discover.
  • Marketplace on, public feed on: show custom MCP galleries before the public GitHub Feed; omit the duplicate default MCP endpoint from Discover. Search still respects relevance ordering.

Validation

  • Focused marketplace, MCP gallery, GitHub Feed provider, installation, Discover, management, MCP workbench, and native composition tests: 358 passing after merging the updated base.
  • npm run typecheck-client, npm run valid-layers-check, targeted ESLint and git diff --check: passing.
  • Live public MCP Gallery browsing was recorded in Code OSS Dev. Installation and component screenshot baselines were not exercised; CI was not awaited.

Dependency

Before / after video

Historical preview at e0aaca6a006, recorded before the separate visibility experiment was added; enable chat.customizations.marketplace.enabled to reproduce the Discover scene on the current branch. Code OSS Dev on macOS: clean main (4212437dd11) with the legacy MCP Servers Available section, followed by this PR (e0aaca6a006) with the MCP Gallery enabled in Discover. Both scenes use the live public MCP gallery; no server was installed. The recording is captioned and each scene was asserted in the scenario report.

pr-337574-before-after.mp4

Paul (pwang347) and others added 30 commits September 21, 2026 11:24
@pwang347
chat: Add AgentFinder marketplace discovery
5f3fcbb 
Add a discovery-only AgentFinder section with metadata cards, GitHub owner avatars, search, filters, pagination, and accessible states. Route desktop catalog requests through a bounded, cancellable shared-process client and preserve encoded resource URLs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Support installing AgentFinder resources
ba0b0cf 
Route validated catalog resources through existing MCP and plugin installation flows, and import complete skill packages into confirmed harness locations. Preserve repository revisions and subdirectories, enforce trust and policy, and cover cancellation, overwrite protection, limits, and installation UI states.

Isolate customization lifecycle tests from production registrations to fix full-suite CI failures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Address AgentFinder review feedback
54a73b3 
Bound catalog metadata before IPC and rendering, bind ResizeObserver to the widget window, preserve catalog state on unrelated entitlement changes, and label Accessible View metadata groups and destinations. Add regression coverage and accept the current AgentFinder screenshot baselines.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
test: Refresh customization navigation screenshot baselines
d33e740 
Accept the verified sidebar and migration-navigation changes caused by the AgentFinder tab. Preserve unrelated baselines and the previously accepted AgentFinder card fixtures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Gate AgentFinder behind an opt-in experiment
c8f3481 
Add chat.agentFinder.enabled with a disabled default and automatic experiment assignment. Gate section visibility and instantiation, catalog IPC and browser clients, and installation observers and work. Keep the shared-process catalog client truly lazy and cancel pending discovery/imports when the experiment is disabled.

Add disabled-path, runtime-toggle and lazy-initialization coverage plus a disabled UI fixture.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge main into pwang/agentfinder-marketplace
bd93f40 
Preserve AgentFinder installation and experiment gating alongside upstream MCP compatibility/detail and migration activity changes. Combine test/fixture imports and retain the latest reviewed MCP screenshot baselines.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Align AgentFinder filter control sizing
c68f228 
Use the standard control height, inherited typography, and padded select treatment so the resource dropdown aligns with search and Refresh on both native and custom select implementations. Assert control geometry in wide and narrow fixtures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Show AgentFinder loading shimmer
e2fa48e 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Isolate AgentFinder REST provider and discovery routing
3704c5b 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Unify customization marketplace discovery sources
ba4ad9e 
Introduce source-neutral marketplace contracts, opaque source-owned pagination, and source/version-scoped identities. Keep AgentFinder as the sole REST-backed source while presenting Marketplace throughout Customizations.

Rename the default-off experiment to chat.customizations.unifiedMarketplace.enabled and retain lazy loading, installation safeguards, and accessibility behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge origin/main into pwang/agentfinder-marketplace
3564d3f 
Preserve the unified customization marketplace and upstream changes. Resolve shared screenshot baseline conflicts in favor of current main while retaining catalog entries pending fresh CI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Unify customization discovery and search
0f8cf8f 
Replace the separate customization overview and AgentFinder section with one Discover surface. Add typed quick filters, grouped virtualized installed and available results, catalog paging and cancellation, and integrated accessibility coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Refine customization discovery controls
8813f9c 
Match the compact customization search sizing, inherit the management surface background, align virtualized results with the page header, and reuse Marketplace filter actions with modern panel-tab filter styling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Align customization discovery cards
9ec074f 
Constrain virtualized selection surfaces to the page measure and give browse cards and search results distinct marketplace-style content hierarchies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
test: Refresh unified marketplace screenshot baselines
fb0376d 
Accept the visually inspected MarketplaceTab and customization navigation images from CI run 35783902863 for head 3564d3f. Preserve all unrelated baselines.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Gate customization marketplace by enabled sources
0a160ad 
Replace the global marketplace experiment with an AgentFinder public-feed source gate. Select sources per window, preserve lazy backends, and scope discovery and installation lifetimes to source enablement.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Add customization marketplace source picker
fd50cb7 
Restore cached Featured items immediately when a search is cleared, and let Discover queries target all registered marketplace feeds or one selected source.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Merge ranked marketplace feeds with bounded pagination
d83276e 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Interleave marketplace feeds while browsing
9a42a6b 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
Merge pwang/agentfinder-marketplace into customization discovery
ba4cf9c 
Integrate per-source marketplace enablement and ranked feed pagination while preserving unified Discover. Reactivate Discover after an editor input is reopened so Agent Finder results are not left cancelled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Refine customization discovery browsing
7fb8b50 
Keep browse content scrollable, quiet non-interactive result headings, and distinguish fallback artwork while aligning the import action with its behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Link customization types from Discover
6274f0c 
Replace the harness-specific Discover description with direct, accessible navigation to each supported customization section.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
chat: Keep healthy marketplace sources available
1660f56 
Report source failures without hiding healthy results, preserve suspended-source state through pagination, and support explicit renderer-owned recovery actions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Simplify customization discovery results
ca78fb0 
Flatten and condense virtualized Discover results, move filters into the search toolbar, and load additional marketplace pages on scroll. Add source provenance and reversible uninstall actions for installed customizations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Present marketplace sign-in as a neutral action
ac89a61 
Distinguish explicit source sign-in from failures in recovery controls, empty states, and accessible content.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Use Public GitHub Feed for marketplace setting and label
32804ea 
Keep the internal catalog integration stable while removing backend branding from the exposed setting and source warnings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
chat: Refine customization discovery density
02a78ce 
Keep metadata beside customization names, tighten result rows, and preserve the subtle Featured surface across themes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge origin/main into pwang/agentfinder-marketplace
cf1beec 
Retain the Marketplace telemetry test setup alongside upstream MCP detail helpers. Preserve all Marketplace source, recovery, ranking, pagination, and source-gating changes.

Resolve six MCP screenshot collisions using upstream baselines from e43c0a0 and 756c3e2; preserve all nonconflicting baselines. Parent images were visually reviewed. The combined Marketplace navigation and updated MCP layouts still require Linux screenshot CI after publication; no local hashes were generated.

Validated fresh transpilation, 413 targeted tests, focused ESLint, editor diagnostics, and merge whitespace checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
test: Refresh merged marketplace screenshot baselines
ec7ccfa 
Accept the six dark/light MCP migration, narrow MCP detail, and migration dashboard hashes from Screenshots & Tests run 35918097764, job 107374755174, for head cf1beec (rendered merge 395b114).

Visually inspect every before/after pair and verify pixel differences are confined to the expected Marketplace/sidebar navigation. Upstream MCP content remains pixel-identical. Preserve all 192 unrelated baselines.

The official screenshotBlocksCi comparator now matches all 198 artifact baselines byte-for-byte. CI passed all 52 Playwright tests and rendered all 3271 fixtures without errors; the six hash mismatches were the only failing step.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Clarify public catalog provider limits
4602506 
Name independent request, pagination, cursor, and installation-provenance bounds without changing their values or behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Paul (pwang347) and others added 5 commits September 23, 2026 17:07
@pwang347
Merge versioned feed installs with configured MCP gallery
cf5c5b7 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Align customization marketplace documentation with current behavior
a3347b1 
Clarify home-surface gating, feed-backed MCP policy, filtered pagination fallback, and current Import actions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Keep marketplace test plan aligned with published Import flow
92f200b 
The expanded targeted Import actions remain uncommitted, so describe only the current PR behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Scope published manual tests to current marketplace behavior
49625d0 
Defer the transient-error scenario until its UI changes are published.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge branch 'pwang/agentfinder-marketplace' into pwang/mcp-gallery-c…
82c8a6d 
…ustomization-feed
Base automatically changed from pwang/agentfinder-marketplace to main September 24, 2026 01:57
@pwang347
Merge main into MCP gallery customization feed
7db6fae 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 24, 2026 07:52
Copilot AI reviewed Sep 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Desktop pagination, registry provenance, terminal service registration, and test structure contain blocking correctness issues.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 High severity · 1 Medium severity · 1 Low severity

Open (4)
What changed in this PR

Adds the MCP Gallery as an independently gated source in Customizations Discover, while preserving registry-specific installation provenance.

Changes:

  • Adds renderer-local MCP Gallery discovery and pagination.
  • Routes MCP discovery from management to Discover when enabled.
  • Extends installation, accessibility, tests, and documentation.
File Description
aiCustomizationManagementEditor.fixture.ts Updates pagination fixture behavior.
mcpWorkbenchService.test.ts Tests cross-registry isolation.
mcpWorkbenchService.ts Validates installed-server registry identity.
mcpListWidget.test.ts Tests gated management discovery.
customizationMarketplaceInstallService.test.ts Tests MCP Gallery installation provenance.
aiCustomizationDiscoveryPage.test.ts Covers MCP Gallery discovery.
chat.shared.contribution.ts Registers experiment and changes chat providers.
mcpListWidget.ts Hides legacy gallery discovery when gated.
customizationMarketplaceWorkbenchService.ts Registers the web Gallery provider.
customizationMarketplaceInstallService.ts Adds Gallery install/uninstall handling.
customizationMarketplace.contribution.ts Updates accessibility help.
aiCustomizationManagementEditor.ts Routes marketplace browsing to Discover.
ai-customizations.test.md Expands manual scenarios.
AI_CUSTOMIZATIONS.md Documents the new source architecture.
mcpGalleryService.test.ts Tests page queries and failures.
mcpManagement.ts Adds paged Gallery contracts.
mcpGalleryService.ts Implements strict paged queries.
customizationMarketplaceService.test.ts Tests native source composition.
mcpGalleryMarketplaceProvider.test.ts Tests metadata mapping and cursors.
customizationMarketplaceService.ts Composes IPC and local providers.
mcpGalleryMarketplaceProvider.ts Adapts Gallery metadata for Discover.
customizationMarketplaceSources.ts Defines the Gallery source and gate.
customizationMarketplaceService.ts Adds Gallery installation provenance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/workbench/contrib/chat/browser/aiCustomization/customizationMarketplaceInstallService.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts Outdated
Comment thread src/vs/platform/customizationMarketplace/electron-browser/customizationMarketplaceService.ts
Comment thread ...tform/customizationMarketplace/test/electron-browser/customizationMarketplaceService.test.ts Outdated
@pwang347
Address MCP gallery marketplace review feedback
e0aaca6 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: b7b87a7a Current: f05b79d8

Changed (3)

chat/scrollAnchoring/chatScrollAnchoring/CompletedOffscreenHeader/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (6)

chat/aiCustomizations/aiCustomizationManagementEditor/LegacyMcpAvailableWithoutMarketplace/Dark

current

chat/aiCustomizations/aiCustomizationManagementEditor/LegacyMcpAvailableWithoutMarketplace/Light

current

chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverWithMcpGalleryOnly/Dark

current

chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverWithMcpGalleryOnly/Light

current

chat/aiCustomizations/aiCustomizationManagementEditor/OverviewWithMarketplaceDisabled/Dark

current

chat/aiCustomizations/aiCustomizationManagementEditor/OverviewWithMarketplaceDisabled/Light

current

Paul (pwang347) and others added 11 commits September 24, 2026 09:57
@pwang347
Fix Discover infinite-scroll component fixture
2898580 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge main and preserve MCP discovery in redesigned list
d7eb5b3 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Restrict MCP Discover to configured custom registry
9e195bf 
Prioritize the custom MCP gallery in browsing and equal-score search while preserving the legacy MCP management gallery when Discover's MCP source is disabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Gate Discover separately from marketplace feeds
6623a69 
Keep legacy MCP Available whenever the default-off Marketplace visibility experiment is disabled. Enable the MCP Discover source by default only inside the Marketplace, independently of the public GitHub Feed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Compose custom and default MCP galleries by public feed state
4172998 
Keep the default MCP gallery in Discover unless the public GitHub Feed is enabled, retain both custom and default results in legacy MCP Available, and pin registry provenance for installation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Align marketplace visibility enum across feed branches
4828d59 
Use MarketplaceEnabled for the shared default-off setting while retaining the established setting key and source-neutral gate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Keep feed enablement independent from Marketplace visibility
012fe3e 
Apply the default-off visibility setting only to Discover, catalog queries and Marketplace installs so legacy management lists can still use independently enabled sources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Preserve legacy feed queries when Discover is hidden
a287235 
Keep source-neutral provider queries gated only by their own source settings; the default-off Marketplace flag controls Discover presentation and Marketplace installation without disabling legacy management catalogs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Format MCP marketplace source tests for hygiene
910b051 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Allow hidden Overview in legacy MCP fixture
74f4fce 
The Marketplace-off home remains available while a management section is selected, but is not itself visible until navigating home.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge marketplace visibility base into MCP gallery feed
98579da 
Preserve source-only legacy queries, shared default-on public feed, and MCP gallery composition behind Marketplace visibility.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Paul (pwang347) changed the base branch from main to pwang/marketplace-visibility-base September 24, 2026 21:11
Paul (pwang347) and others added 5 commits September 24, 2026 14:11
@pwang347
Keep unrelated chat contribution timing out of MCP PR
b23ca5a 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge marketplace visibility and source priority
d4aadae 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Merge remote-tracking branch 'origin/pwang/marketplace-visibility-bas…
26c1c62 
…e' into pwang/mcp-gallery-customization-feed
@pwang347
Keep Marketplace hidden in MCP visibility test
a06aa4c 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Fix MCP gallery registry provenance
7085252 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

@pwang347 Paul (pwang347)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pwang347 @houghj16