Fix VSTHRD107 to detect unawaited tasks in using variable declarations

[Austin Aviv (Austinviv)]

Fixes #1697

Description

This PR expands VSTHRD107AwaitTaskWithinUsingExpressionAnalyzer and VSTHRD107AwaitTaskWithinUsingExpressionCodeFix to detect and fix unawaited Task / Task expressions when used within using variable declarations:

• using (var releaser = semaphore.EnterAsync())
• using (IDisposable releaser = semaphore.EnterAsync())
• using var releaser = semaphore.EnterAsync(); (C# 8 using declarations)

Background

Because Task implements IDisposable, storing an unawaited task in a using variable declaration compiles without warning, but disposes the unawaited task instance instead of awaiting the releaser.

Previously, VSTHRD107 only inspected UsingStatementSyntax.Expression. It missed declaration forms, and VSTHRD107AwaitTaskWithinUsingExpressionCodeFix threw an exception when .Expression was null.

Changes

1. Analyzer:
   • Registered SyntaxKind.LocalDeclarationStatement in addition to SyntaxKind.UsingStatement.
   • Added checking for usingStatement.Declaration and localDeclaration.Declaration variable initializers.
   • Handled C# 8 using var declarations (ignoring wait using).
2. Code Fix:
   • Replaced direct mutation of usingStatement.Expression with node replacement targeting the containing statement (ReplaceExpressionWithAwait).
   • Cleanly wraps expressions with wait without unnecessary parentheses around invocations or identifier names.
3. Docs and Tests:
   • Updated documentation in docfx/analyzers/VSTHRD107.md.
   • Added unit tests covering sync and async methods, using (var ...), using var ...;, and explicit IDisposable type annotations.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

🟡 Changes recommended

Some offered fixes produce uncompilable code for unsupported containing functions or tasks without disposable results.

1 open finding

• Make the nearest await-capable function async · New

What changed in this PR

Expands VSTHRD107 to detect unawaited tasks in using declarations and updates its code fix.

Changes:

• Analyzes using-statement and C# 8 using-declaration initializers.
• Reworks code-fix expression replacement.
• Adds documentation and test coverage.

File	Description
VSTHRD107AwaitTaskWithinUsingExpressionAnalyzerTests.cs	Tests new declaration forms.
VSTHRD107AwaitTaskWithinUsingExpressionAnalyzer.cs	Analyzes using-variable initializers.
VSTHRD107AwaitTaskWithinUsingExpressionCodeFix.cs	Adds await to diagnosed expressions.
VSTHRD107.md	Documents supported forms.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Austin Aviv (Austinviv)]

Hi, could any maintainer please review and approve this PR when you get a chance? I'd like to check the workflow test results to see how many tests passed and failed. Thank you!

[Austin Aviv (Austinviv)]

Hi maintainers, could you please approve the workflow run for this PR? Thank you!

[Drew Noakes (drewnoakes)]

Austin (@AustinAviv) I approved the workflows to run. I'll defer to Andrew Arnott (@AArnott) for the actual merge.

[Austin Aviv (Austinviv)]

Austin (Austin (@AustinAviv)) I approved the workflows to run. I'll defer to Andrew Arnott (Andrew Arnott (@AArnott)) for the actual merge.

Hi Andrew Arnott (@AArnott) Drew Noakes (@drewnoakes), thanks, Drew, for approving the previous workflow run! Could you please approve the new workflow run as well if approval is required? Andrew, when you get a chance, I'd appreciate your review of this PR. I'm happy to address any feedback or make further changes. Thanks both for your time and support!

[Drew Noakes (drewnoakes)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).

[Austin Aviv (Austinviv)]

/azp run

Thanks Drew Noakes (Drew Noakes (@drewnoakes))for approving the workflow run

Let me know if you have any additional queries regarding this PR.

[Andrew Arnott (AArnott)]

Thanks for submitting. I look forward to merging after a couple of small fixes.

[Andrew Arnott (AArnott)]

"if the await keyword is an await keyword"?? This deserves a code comment explaining why it makes sense.

[Copilot]

🟡 Changes recommended

The code fix can introduce compiler errors for explicitly task-typed declarations.

1 open finding

• Update task-typed using declarations when adding await · New

1 resolved since last review

• Make the nearest await-capable function async

🧠 Review effort: Balanced

[Austin Aviv (Austinviv)]

Thanks for submitting. I look forward to merging after a couple of small fixes.

Thanks for the review Andrew Arnott (@AArnott) I'll address the feedback by adding an explanatory comment for the AwaitKeyword check and reviewing the code-fix edge cases to ensure the generated fixes are valid. I'll push the updates and verify the tests before requesting another review. Thanks for the guidance!

[Copilot]

🔵 Needs a closer look

The code fix can produce uncompilable code for explicitly task-typed declarations and contexts that prohibit awaiting.

0 open findings

1 resolved since last review

• Update task-typed using declarations when adding await

🧠 Review effort: Balanced