Skip to content

Allow ORT GenAI callers to disable vendor image codecs - #1144

Open
lsmlhi_25 (FOWEPJF255) wants to merge 1 commit into
microsoft:mainfrom
FOWEPJF255:fix/ort-genai-vendor-codec-override
Open

lsmlhi_25 (FOWEPJF255) wants to merge 1 commit into
microsoft:mainfrom
FOWEPJF255:fix/ort-genai-vendor-codec-override

Conversation

@FOWEPJF255

Copy link
Copy Markdown

Summary

The ORT GenAI preset currently forces OCOS_ENABLE_VENDOR_IMAGE_CODECS=ON, overriding an explicit -DOCOS_ENABLE_VENDOR_IMAGE_CODECS=OFF. Remove that preset assignment so the root CMakeLists.txt option continues to default to ON while callers can opt out. This addresses microsoft/onnxruntime-genai#1737.

Validation

  • Reproduced before the change: explicit OFF became ON after loading the preset, with an INTERNAL cache entry.
  • With CMake 3.31.10, a configuration fixture that declares the root option before including the real preset passed default ON, explicit ON, explicit OFF, and OFF/ON/OFF changes in a reused cache.
  • git diff --check passed.

I did not run a native C++ build on this Windows host because the required compiler toolchain is unavailable. The change is limited to one CMake preset assignment.

@FOWEPJF255
lsmlhi_25 (FOWEPJF255) requested a review from a team as a code owner October 27, 2026 02:42
Copilot AI balanced review requested due to automatic review settings October 27, 2026 02:42
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow removal preserves the default, respects caller overrides, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR lets ORT GenAI callers disable vendor image codecs while preserving the root CMake option’s default of ON, addressing microsoft/onnxruntime-genai#1737.

Changes:

  • Removes the preset assignment that forcibly enabled vendor image codecs.
  • Allows explicit caller settings, including OFF, to remain effective.
File Description
cmake/​presets/​ort_genai.cmake Removes the forced vendor image codec setting.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants