Repository navigation
Allow ORT GenAI callers to disable vendor image codecs - #1144
Open
lsmlhi_25 (FOWEPJF255) wants to merge 1 commit into
Open
lsmlhi_25 (FOWEPJF255) wants to merge 1 commit into
lsmlhi_25 (FOWEPJF255) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow removal preserves the default, respects caller overrides, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR lets ORT GenAI callers disable vendor image codecs while preserving the root CMake option’s default of ON, addressing microsoft/onnxruntime-genai#1737.
Changes:
- Removes the preset assignment that forcibly enabled vendor image codecs.
- Allows explicit caller settings, including OFF, to remain effective.
| File | Description |
|---|---|
cmake/presets/ort_genai.cmake |
Removes the forced vendor image codec setting. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ORT GenAI preset currently forces
OCOS_ENABLE_VENDOR_IMAGE_CODECS=ON, overriding an explicit-DOCOS_ENABLE_VENDOR_IMAGE_CODECS=OFF. Remove that preset assignment so the rootCMakeLists.txtoption continues to default to ON while callers can opt out. This addresses microsoft/onnxruntime-genai#1737.Validation
git diff --checkpassed.I did not run a native C++ build on this Windows host because the required compiler toolchain is unavailable. The change is limited to one CMake preset assignment.