Repository navigation
Fix connection byte offsets and Ethernet chunk accounting - #936
Draft
Changho Hwang (chhwang) wants to merge 2 commits into
Draft
Changho Hwang (chhwang) wants to merge 2 commits into
Changho Hwang (chhwang) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CudaIpcConnection::updateAndSyncapplying its byte offset twice; the copy and log now use the already offset destination pointer.EthernetConnection::writecounting the initial frame header as payload progress, which skipped bytes on chunked writes.CommunicatorTest.BasicWriteandPortChannelOneToOneTest.PingPongEthernet. No standalone tests were added, and performance tests and production staging-buffer defaults are unchanged.Regression coverage
BasicWriteexercises nonzero byte offsets only on existing CudaIpc connections; IB connections skip that per-edge phase while all ranks keep the same barriers. Per-sender slots and a guard at the former9 * dstOffsettarget are checked. A uniform capacity guard skips only this added phase if its largest guard address will not fit the fixture buffer.PingPongEthernetretains its original ping-pong exercise, then uses the existing bootstrap and memory-pair helpers with a 64-byte staging buffer to verify a 128-byte chunked write followed by a 16-byte frame. It follows the existing two-participant fixture; additional world ranks take the fixture's existing nonparticipant path.Validation
clang-format --dry-run --Werrorandgit diff --checkpassed.