fix(json): distinguish null from the none enum member - #762
Open
Shubham Padkonde (Shubham-Padkonde) wants to merge 1 commit into
Open
Shubham Padkonde (Shubham-Padkonde) wants to merge 1 commit into
Shubham Padkonde (Shubham-Padkonde) wants to merge 1 commit into
Conversation
Shubham Padkonde (Shubham-Padkonde)
requested a review
from a team
as a code owner
October 4, 2026 07:57
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Overview
Preserve JSON
nullwhen parsing an enum that has aNone_ = "none"member. Currentlystr(None)becomes"None", which takes the reserved-keyword handling path and returns the actual enum member. A missing value can therefore be mistaken for an explicitly supplied"none"value.Return
Nonebefore converting a null node to text. The wire value"none"still resolves toNone_, and ordinary enum values are unchanged. Collection entries use the same correction.Related Issue
No separate issue found. The regression is reproduced by
JsonParseNode(None).get_enum_value()with an enum containingNone_ = "none".Testing Instructions
packages/serialization/json, runpython -m pytest tests -q: all 200 tests pass."none"and"low"remain valid.Pylint rates the source 10/10 but reports the existing
suggestion-modeconfiguration option as unrecognized in the installed version.