[Hardik K (hardikkaurani)]

Description

This PR strengthens AllowedHostsValidator.isUrlHostValid(URI) in kiota-java:

1. Validation & userinfo rejection:

   • Retains @Nonnull final URI uri and validates via Objects.requireNonNull(uri, "parameter uri cannot be null") to fail fast, preserving compile-time and static analysis safety.
   • Validates that uri.getScheme() and uri.getHost() are non-empty before proceeding, preventing unexpected exceptions on opaque URIs (e.g. mailto:, URNs, or relative path URIs).
   • Rejects URIs containing userinfo (uri.getUserInfo() != null && !uri.getUserInfo().isEmpty()) to protect against host spoofing and credential leaks (consistent with other Kiota SDKs).
   • Enforces URI structure and userinfo rejection even when allowedHosts is empty (validHosts.isEmpty()).

2. Tests:

   • Added unit tests covering defensive null handling, URIs without scheme/host, URIs with userinfo, and empty allowedHosts validation.

cc Vincent Biret (@baywet)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet), submitted this PR to add null checks and userinfo rejection in AllowedHostsValidator with full unit tests. All checks and builds are green. Whenever you have some time, could you please review? Thank you!

[Copilot]

🟢 Approval recommended

The focused validation changes match the stated requirements, include regression coverage, and have no identified blocking issues.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

🟢 Approval recommended

The focused validation changes and regression tests have no identified blocking issues; tests were not executed.

No open issues 🎉

_{Review effort: Balanced}

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet),

Following up on the review feedback:

• Retained @Nonnull final URI uri and added Objects.requireNonNull(uri, "parameter uri cannot be null") to preserve static analysis and compile-time guarantees while failing fast at runtime.
• Updated the test suite to verify NullPointerException for null URIs (using the project's nullValue() helper to satisfy SpotBugs).
• All CI checks, CodeQL, API level linter, and Gradle builds are passing green, with no open issues.

Whenever you have a moment, could you please take another look? Thank you!