Repository navigation
Avoid clearing com_array object representation - #1642
Open
Daniel Jump (DanielJump) wants to merge 2 commits into
Open
Daniel Jump (DanielJump) wants to merge 2 commits into
Daniel Jump (DanielJump) wants to merge 2 commits into
Conversation
Reset the detached array's data and size members explicitly so detach_abi does not write through the representation of a non-trivially-copyable object. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8b45cfea-cc0f-4a1f-8b2a-86c89d063c6c Hostname: DanJump0
Reset the com_array members after the compiler-specific result construction so both paths use the same ownership-release logic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8b45cfea-cc0f-4a1f-8b2a-86c89d063c6c Hostname: DanJump0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memsetof the non-trivially-copyablecom_arrayobject with explicit data and size resetsThe existing MSVC
std::pairpadding workaround remains unchanged.Validation
test_old.exe '*detach*': 18 assertions in 5 test cases passed