Loosen lib types for string methods that internally call %Symbol.*% methods by graphemecluster · Pull Request #64442 · microsoft/TypeScript

graphemecluster (graphemecluster) · 2026-09-25T00:01:15Z

This is intended as a more general fix to #54387.
Out of String.{replace,match}{,All}, .search and .split, modify or add signatures involving custom objects implementing well-known symbol methods, the parameter and return types of which are now preserved (yes, per the spec they just directly call the raw value and return the raw result. There is no type coercion involved, so I think it is acceptable to define them like this).
The addition of replaceAll and matchAll signatures ensures their definitions are parallel to their equivalent without All.
The wordings of the documentation are adjusted accordingly.

Fixes #54387
Fixes #61448

^{For historical reference, most of this PR was extracted from #60249 (generic RegExp is excluded of course).}

…ethods

Copilot

Copilot review overview

🟡 Changes recommended

The new replacement signatures introduce implicit-any regressions and the custom-symbol inference behavior lacks focused tests.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: None

What changed in this PR

This PR broadens String well-known-symbol method typings to preserve custom argument and return types.

Changes:

Adds generic custom-symbol overloads for matching, replacing, searching, and splitting.
Expands matchAll/replaceAll inputs and revises documentation.
Updates affected compiler and call-hierarchy baselines.

File	Description
`tsc/testdata/baselines/reference/fourslash/callHierarchy/callHierarchyInPropDeclarationOfExportedDefaultClass1.callHierarchy.txt`	Updates shifted library spans.
`tsc/testdata/baselines/reference/fourslash/callHierarchy/callHierarchyIncomingCallsObjectLiteralMethodInStringLiteralComputedProperty.callHierarchy.txt`	Updates `split` hierarchy output.
`tsc/testdata/baselines/reference/fourslash/callHierarchy/callHierarchyIncomingCallsObjectLiteralMethodInIdentifierComputedProperty.callHierarchy.txt`	Updates `split` hierarchy output.
`tsc/testdata/baselines/reference/fourslash/callHierarchy/callHierarchyIncomingCallsObjectLiteralMethodInExpressionComputedProperty.callHierarchy.txt`	Updates `split` hierarchy output.
`tsc/testdata/baselines/reference/fourslash/callHierarchy/callHierarchyIncomingCallsNoCrashArrayPush.callHierarchy.txt`	Updates shifted library spans.
`tsc/testdata/baselines/reference/conformance/useRegexpGroups.types`	Records generic `match` overload.
`tsc/testdata/baselines/reference/conformance/parserRealSource11.types`	Records revised `replace` and `split` types.
`tsc/testdata/baselines/reference/conformance/parserRealSource11.symbols`	Updates `replace` declarations.
`tsc/testdata/baselines/reference/conformance/parserharness.types`	Records consolidated `replace` signature.
`tsc/testdata/baselines/reference/conformance/parserharness.symbols`	Updates `replace` symbols.
`tsc/testdata/baselines/reference/conformance/parserArgumentList1.types`	Records lost callback contextual types.
`tsc/testdata/baselines/reference/conformance/parserArgumentList1.symbols`	Updates `replace` declarations.
`tsc/testdata/baselines/reference/conformance/parserArgumentList1.errors.txt`	Adds callback implicit-any diagnostics.
`tsc/testdata/baselines/reference/conformance/parser630933.types`	Records generic `match` overload.
`tsc/testdata/baselines/reference/compiler/stringMatchAll.types`	Records expanded `matchAll` signatures.
`tsc/testdata/baselines/reference/compiler/stringMatchAll.symbols`	Records added `matchAll` declaration.
`tsc/testdata/baselines/reference/compiler/regExpWithSlashInCharClass.types`	Records revised `replace` types.
`tsc/testdata/baselines/reference/compiler/regExpWithSlashInCharClass.symbols`	Updates `replace` declarations.
`tsc/testdata/baselines/reference/compiler/regexMatchAll.types`	Updates parameter naming.
`tsc/testdata/baselines/reference/compiler/regexMatchAll-esnext.types`	Updates parameter naming.
`tsc/testdata/baselines/reference/compiler/overloadResolutionOverNonCTLambdas.types`	Records revised `replace` overloads.
`tsc/testdata/baselines/reference/compiler/overloadResolutionOverNonCTLambdas.symbols`	Updates `replace` declarations.
`tsc/testdata/baselines/reference/compiler/noImplicitAnyInContextuallyTypesFunctionParamter.types`	Records revised `replace` overloads.
`tsc/testdata/baselines/reference/compiler/noImplicitAnyInContextuallyTypesFunctionParamter.symbols`	Updates `replace` declarations.
`tsc/testdata/baselines/reference/compiler/narrowingWithNonNullExpression.types`	Records generic `match` overload.
`tsc/testdata/baselines/reference/compiler/initializedDestructuringAssignmentTypes.types`	Records generic `match` overload.
`tsc/testdata/baselines/reference/compiler/flatArrayNoExcessiveStackDepth.types`	Records generic `match` overload.
`tsc/testdata/baselines/reference/compiler/firstMatchRegExpMatchArray.types`	Records generic `match` overload.
`tsc/testdata/baselines/reference/compiler/extendGlobalThis.types`	Records generic `split` overload.
`tsc/testdata/baselines/reference/compiler/doYouNeedToChangeYourTargetLibraryES2016Plus.types`	Records generic `match` overload.
`tsc/testdata/baselines/reference/compiler/controlFlowPropertyDeclarations.types`	Records revised `replace` types.
`tsc/testdata/baselines/reference/compiler/controlFlowPropertyDeclarations.symbols`	Updates `replace` declarations.
`tsc/testdata/baselines/reference/compiler/bestChoiceType.types`	Records generic `match` overload.
`tsc/internal/bundled/libs/lib.es5.d.ts`	Revises core string signatures and docs.
`tsc/internal/bundled/libs/lib.es2021.string.d.ts`	Expands `replaceAll` overloads.
`tsc/internal/bundled/libs/lib.es2020.symbol.wellknown.d.ts`	Revises `RegExp.matchAll` documentation.
`tsc/internal/bundled/libs/lib.es2020.string.d.ts`	Expands `String.matchAll`.
`tsc/internal/bundled/libs/lib.es2015.symbol.wellknown.d.ts`	Generalizes well-known-symbol dispatch.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Daniel Rosenwasser (DanielRosenwasser) · 2026-09-25T00:08:40Z

+     * @param replaceValue A value to be passed into {@linkcode searchValue}.
     */
-    replace(searchValue: { [Symbol.replace](string: string, replacer: (substring: string, ...args: any[]) => string): string; }, replacer: (substring: string, ...args: any[]) => string): string;
+    replace<This, T, R>(this: This, searchValue: { [Symbol.replace](string: This, replaceValue: T): R; }, replaceValue: T): R;


I think a while back we decided not to thread through this parameters in methods with callbacks because of perf costs. Maybe it matters less now.

Daniel Rosenwasser (DanielRosenwasser) · 2026-09-25T00:08:57Z

TypeScript Bot (@typescript-bot) test it

typescript-automation · 2026-09-25T00:09:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-automation · 2026-09-25T00:33:36Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - native}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_115,480	_115,514	_{+34 (+ 0.03%)}	_~	_~	_{p=0.000 n=12}
_Types	_96,949	_96,980	_{+31 (+ 0.03%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{148,741k (± 0.47%)}	_{147,962k (± 0.28%)}	_~	_146,946k	_148,998k	_{p=0.089 n=12}
_{Memory Allocs}	_{2,271,678 (± 0.00%)}	_{2,272,571 (± 0.00%)}	_{+893 (+ 0.04%)}	_2,272,224	_2,272,778	_{p=0.000 n=12}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.040s (± 4.38%)}	_{0.041s (± 4.12%)}	_~	_0.037s	_0.046s	_{p=0.280 n=12}
_{Bind Time}	_{0.012s (± 9.31%)}	_{0.014s (±13.69%)}	_~	_0.010s	_0.019s	_{p=0.171 n=12}
_{Check Time}	_{0.503s (± 1.01%)}	_{0.500s (± 0.68%)}	_~	_0.494s	_0.511s	_{p=0.296 n=12}
_{Emit Time}	_{0.266s (± 2.09%)}	_{0.272s (± 2.05%)}	_~	_0.258s	_0.287s	_{p=0.164 n=12}
_{Total Time}	_{0.827s (± 0.94%)}	_{0.833s (± 0.82%)}	_~	_0.814s	_0.853s	_{p=0.103 n=12}
_{angular-1 - native}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_{847,544 (± 0.04%)}	_{854,952 (± 0.08%)}	_{+7,408 (+ 0.87%)}	_852,987	_856,891	_{p=0.000 n=12}
_Types	_{250,004 (± 0.00%)}	_{253,414 (± 0.00%)}	_{+3,410 (+ 1.36%)}	_253,411	_253,423	_{p=0.000 n=12}
_{Memory Used}	_{793,465k (± 0.04%)}	_{797,504k (± 0.07%)}	_{+4,039k (+ 0.51%)}	_796,004k	_799,636k	_{p=0.000 n=12}
_{Memory Allocs}	_{12,959,106 (± 0.04%)}	_{12,992,478 (± 0.05%)}	_{+33,372 (+ 0.26%)}	_12,984,788	_13,015,318	_{p=0.000 n=12}
_{Config Time}	_0.016s	_0.016s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.271s (± 3.41%)}	_{0.267s (± 2.73%)}	_~	_0.251s	_0.287s	_{p=0.560 n=12}
_{Bind Time}	_{0.068s (±18.70%)}	_{0.069s (±15.23%)}	_~	_0.057s	_0.102s	_{p=0.655 n=12}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=12}
_{Emit Time}	_{1.627s (± 1.52%)}	_{1.633s (± 1.60%)}	_~	_1.593s	_1.694s	_{p=0.944 n=12}
_{Total Time}	_{1.999s (± 1.66%)}	_{2.005s (± 1.80%)}	_~	_1.950s	_2.094s	_{p=0.943 n=12}
_{mui-docs - native}
_Errors	_{11,402 (± 0.04%)}	_{11,404 (± 0.03%)}	_~	_11,391	_11,408	_{p=0.343 n=12}
_Symbols	_4,402,219	_5,009,326	_{🔻+607,107 (+13.79%)}	_~	_~	_{p=0.000 n=12}
_Types	_1,489,173	_1,706,097	_{🔻+216,924 (+14.57%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{4,787,797k (± 0.04%)}	_{5,675,094k (± 0.03%)}	_{🔻+887,296k (+18.53%)}	_5,671,089k	_5,679,377k	_{p=0.000 n=12}
_{Memory Allocs}	_{42,335,079 (± 0.05%)}	_{52,264,445 (± 0.03%)}	_{🔻+9,929,366 (+23.45%)}	_52,214,890	_52,307,849	_{p=0.000 n=12}
_{Config Time}	_{0.016s (± 2.12%)}	_{0.015s (± 2.02%)}	_~	_0.015s	_0.016s	_{p=0.680 n=12}
_{Parse Time}	_{0.568s (± 1.86%)}	_{0.561s (± 1.95%)}	_~	_0.528s	_0.585s	_{p=0.297 n=12}
_{Bind Time}	_0.002s	_0.002s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{15.333s (± 0.31%)}	_{15.870s (± 0.35%)}	_{+0.537s (+ 3.50%)}	_15.760s	_16.025s	_{p=0.000 n=12}
_{Emit Time}	_{0.463s (± 5.52%)}	_{0.483s (±10.71%)}	_~	_0.427s	_0.645s	_{p=0.503 n=12}
_{Total Time}	_{17.138s (± 0.38%)}	_{17.692s (± 0.33%)}	_{+0.554s (+ 3.23%)}	_17.548s	_17.843s	_{p=0.000 n=12}
_{strada-build-src - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,394,252	_1,395,757	_{+1,505 (+ 0.11%)}	_~	_~	_{p=0.000 n=12}
_Types	_443,566	_445,041	_{+1,475 (+ 0.33%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{1,666,636k (± 0.71%)}	_{1,655,219k (± 0.20%)}	_~	_1,646,169k	_1,664,109k	_{p=0.319 n=12}
_{Memory Allocs}	_{83,644,902 (± 0.04%)}	_{83,464,463 (± 0.02%)}	_{-180,439 (- 0.22%)}	_83,425,020	_83,504,430	_{p=0.000 n=12}
_{Config Time}	_{0.004s (±12.82%)}	_{0.004s (±13.87%)}	_~	_0.003s	_0.006s	_{p=0.721 n=12}
_{Parse Time}	_{0.271s (± 2.72%)}	_{0.270s (± 1.92%)}	_~	_0.260s	_0.287s	_{p=0.989 n=12}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{1.839s (± 0.72%)}	_{1.789s (± 0.61%)}	_{-0.050s (- 2.72%)}	_1.767s	_1.812s	_{p=0.000 n=12}
_{Emit Time}	_{0.284s (± 4.24%)}	_{0.291s (± 3.05%)}	_~	_0.268s	_0.312s	_{p=0.442 n=12}
_{Total Time}	_{21.167s (± 0.91%)}	_{21.021s (± 0.56%)}	_~	_20.695s	_21.245s	_{p=0.319 n=12}
_{strada-compiler - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_337,531	_338,081	_{+550 (+ 0.16%)}	_~	_~	_{p=0.000 n=12}
_Types	_198,885	_198,716	_{-169 (- 0.08%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{319,603k (± 0.03%)}	_{319,074k (± 0.02%)}	_{-529k (- 0.17%)}	_318,899k	_319,240k	_{p=0.000 n=12}
_{Memory Allocs}	_{4,672,840 (± 0.01%)}	_{4,664,718 (± 0.01%)}	_{-8,123 (- 0.17%)}	_4,663,306	_4,666,471	_{p=0.000 n=12}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.113s (± 3.76%)}	_{0.112s (± 4.53%)}	_~	_0.103s	_0.128s	_{p=0.579 n=12}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Check Time}	_{1.074s (± 0.50%)}	_{1.072s (± 0.48%)}	_~	_1.062s	_1.087s	_{p=0.451 n=12}
_{Emit Time}	_{0.137s (±10.27%)}	_{0.123s (±13.28%)}	_~	_0.095s	_0.159s	_{p=0.173 n=12}
_{Total Time}	_{1.375s (± 0.77%)}	_{1.361s (± 1.44%)}	_~	_1.312s	_1.423s	_{p=0.103 n=12}
_{ts-pre-modules - native}
_Errors	₈₇	₈₇	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_305,179	_304,022	_{-1,157 (- 0.38%)}	_~	_~	_{p=0.000 n=12}
_Types	_181,926	_181,214	_{-712 (- 0.39%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{277,127k (± 0.02%)}	_{276,021k (± 0.07%)}	_{-1,106k (- 0.40%)}	_275,051k	_276,268k	_{p=0.000 n=12}
_{Memory Allocs}	_{1,641,995 (± 0.01%)}	_{1,679,101 (± 0.01%)}	_{+37,106 (+ 2.26%)}	_1,678,331	_1,679,693	_{p=0.000 n=12}
_{Config Time}	_{0.001s (±65.70%)}	_{0.000s (±113.79%)}	_~	_0.000s	_0.001s	_{p=0.400 n=12}
_{Parse Time}	_{0.099s (± 3.73%)}	_{0.099s (± 4.27%)}	_~	_0.088s	_0.109s	_{p=0.898 n=12}
_{Bind Time}	_{0.038s (±10.80%)}	_{0.040s (±11.11%)}	_~	_0.029s	_0.050s	_{p=0.485 n=12}
_{Check Time}	_{0.838s (± 0.34%)}	_{0.854s (± 1.76%)}	_{+0.015s (+ 1.83%)}	_0.834s	_0.925s	_{p=0.006 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{0.988s (± 0.63%)}	_{1.006s (± 1.45%)}	_{+0.018s (+ 1.78%)}	_0.986s	_1.075s	_{p=0.007 n=12}
_{vscode - native}
_Errors	₃₇₁	₃₇₁	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_9,677,458	_9,677,948	_{+490 (+ 0.01%)}	_~	_~	_{p=0.000 n=12}
_Types	_3,258,672	_3,258,976	_{+304 (+ 0.01%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{6,376,637k (± 0.02%)}	_{6,378,036k (± 0.01%)}	_{+1,399k (+ 0.02%)}	_6,376,507k	_6,379,501k	_{p=0.010 n=12}
_{Memory Allocs}	_{48,938,156 (± 0.01%)}	_{48,992,269 (± 0.01%)}	_{+54,113 (+ 0.11%)}	_48,985,955	_49,011,135	_{p=0.000 n=12}
_{Config Time}	_{0.066s (± 0.55%)}	_{0.066s (± 0.41%)}	_~	_0.065s	_0.067s	_{p=0.496 n=12}
_{Parse Time}	_{1.805s (± 2.41%)}	_{1.767s (± 3.67%)}	_~	_1.652s	_1.945s	_{p=0.213 n=12}
_{Bind Time}	_{0.471s (±12.02%)}	_{0.600s (±19.42%)}	_~	_0.400s	_0.849s	_{p=0.086 n=12}
_{Check Time}	_{12.874s (± 1.27%)}	_{12.743s (± 1.38%)}	_~	_12.492s	_13.105s	_{p=0.192 n=12}
_{Emit Time}	_{4.463s (±12.60%)}	_{4.782s (±10.91%)}	_~	_3.660s	_5.558s	_{p=0.590 n=12}
_{Total Time}	_{19.793s (± 2.21%)}	_{20.071s (± 2.03%)}	_~	_19.162s	_20.688s	_{p=0.219 n=12}
_{webpack - native}
_Errors	₈₄₈	₈₅₀	_{+2 (+ 0.24%)}	_~	_~	_{p=0.000 n=12}
_Symbols	_1,358,721	_1,438,463	_{🔻+79,742 (+ 5.87%)}	_~	_~	_{p=0.000 n=12}
_Types	_597,693	_613,701	_{+16,008 (+ 2.68%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{954,323k (± 0.02%)}	_{990,022k (± 0.01%)}	_{+35,699k (+ 3.74%)}	_989,709k	_990,429k	_{p=0.000 n=12}
_{Memory Allocs}	_{6,224,215 (± 0.02%)}	_{6,346,064 (± 0.02%)}	_{+121,849 (+ 1.96%)}	_6,344,351	_6,349,653	_{p=0.000 n=12}
_{Config Time}	_0.009s	_0.009s	_~	_~	_~	_{p=1.000 n=12}
_{Parse Time}	_{0.264s (± 3.13%)}	_{0.261s (± 1.78%)}	_~	_0.248s	_0.274s	_{p=0.339 n=12}
_{Bind Time}	_{0.065s (±18.85%)}	_{0.067s (±16.49%)}	_~	_0.053s	_0.100s	_{p=0.405 n=12}
_{Check Time}	_{2.230s (± 0.86%)}	_{1.943s (± 0.44%)}	_{🟩-0.287s (-12.87%)}	_1.923s	_1.965s	_{p=0.000 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{2.602s (± 0.51%)}	_{2.317s (± 0.28%)}	_{🟩-0.285s (-10.97%)}	_2.301s	_2.337s	_{p=0.000 n=12}
_{xstate-main - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=12}
_Symbols	_1,045,695	_1,033,895	_{-11,800 (- 1.13%)}	_~	_~	_{p=0.000 n=12}
_Types	_383,049	_378,220	_{-4,829 (- 1.26%)}	_~	_~	_{p=0.000 n=12}
_{Memory Used}	_{611,284k (± 0.02%)}	_{608,468k (± 0.02%)}	_{-2,816k (- 0.46%)}	_608,183k	_608,673k	_{p=0.000 n=12}
_{Memory Allocs}	_{4,830,656 (± 0.04%)}	_{4,793,506 (± 0.04%)}	_{-37,150 (- 0.77%)}	_4,790,784	_4,802,515	_{p=0.000 n=12}
_{Config Time}	_{0.003s (±12.54%)}	_0.003s	_{🔻+0.000s (+16.13%)}	_~	_~	_{p=0.037 n=12}
_{Parse Time}	_{0.148s (± 3.98%)}	_{0.152s (± 3.53%)}	_~	_0.138s	_0.163s	_{p=0.354 n=12}
_{Bind Time}	_{0.046s (±16.30%)}	_{0.043s (±17.12%)}	_~	_0.034s	_0.068s	_{p=0.721 n=12}
_{Check Time}	_{1.204s (± 0.70%)}	_{1.146s (± 1.34%)}	_{🟩-0.058s (- 4.81%)}	_1.104s	_1.200s	_{p=0.000 n=12}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=12}
_{Total Time}	_{1.412s (± 0.89%)}	_{1.353s (± 1.11%)}	_{🟩-0.059s (- 4.15%)}	_1.312s	_1.397s	_{p=0.000 n=12}

System info unknown

Hosts

native

Scenarios

Compiler-Unions - native
angular-1 - native
mui-docs - native
strada-build-src - native
strada-compiler - native
ts-pre-modules - native
vscode - native
webpack - native
xstate-main - native

_Benchmark	_Name	_Iterations
_Current	_pr	₁₂
_Baseline	_baseline	₁₂

Developer Information:

Download Benchmarks

typescript-automation · 2026-09-25T00:40:40Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user tests with tsc comparing main and refs/pull/64442/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

test/tsconfig.json

[NEW] error TS7053: Element implicitly has an 'any' type because expression of type '1' can't be used to index type '{}'.
- test/src/evaluation.test.ts#L90 in test/tsconfig.json

webpack

tsconfig.json

[NEW] error TS7006: Parameter 'match' implicitly has an 'any' type.
- lib/devtool/ModuleFilenameHelpers.js#L285
[NEW] error TS7006: Parameter 'content' implicitly has an 'any' type.
- lib/devtool/ModuleFilenameHelpers.js#L285

tsconfig.types.json

[NEW] error TS7006: Parameter 'match' implicitly has an 'any' type.
- lib/devtool/ModuleFilenameHelpers.js#L285
[NEW] error TS7006: Parameter 'content' implicitly has an 'any' type.
- lib/devtool/ModuleFilenameHelpers.js#L285

tsconfig.types.test.json

[NEW] error TS7006: Parameter 'match' implicitly has an 'any' type.
- lib/devtool/ModuleFilenameHelpers.js#L285
[NEW] error TS7006: Parameter 'content' implicitly has an 'any' type.
- lib/devtool/ModuleFilenameHelpers.js#L285

typescript-automation · 2026-09-25T01:22:48Z

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/64442/merge:

Something interesting changed - please have a look.

Details

diegosouzapw/OmniRoute

4 of 10 projects failed to build with the old tsc and were ignored

open-sse/tsconfig.json

error TS2339: Property 'join' does not exist on type 'unknown'.
- open-sse/services/signatureCache.ts#L131

neoclide/coc.nvim

tsconfig.json

error TS2339: Property 'index' does not exist on type 'unknown'.
- src/list/worker.ts#L288
- src/list/worker.ts#L289

tsconfig.test.json

error TS2339: Property 'index' does not exist on type 'unknown'.
- src/list/worker.ts#L288
- src/list/worker.ts#L289

SBoudrias/Inquirer.js

tsconfig.json

error TS2571: Object is of type 'unknown'.
- packages/inquirer/src/ui/prompt.ts#L45

packages/inquirer/tsconfig.json

error TS2571: Object is of type 'unknown'.
- packages/inquirer/src/ui/prompt.ts#L45

stablyai/orca

14 of 23 projects failed to build with the old tsc and were ignored

config/tsconfig.cli.json

error TS2345: Argument of type '(this: string, separator: unknown, limit?: number) => string[]' is not assignable to parameter of type '(splitter: { [Symbol.split](string: unknown, limit?: unknown): unknown; }, limit?: unknown) => unknown'.
- src/shared/git-history-message-allocation.test.ts#L21 in config/tsconfig.cli.json

config/tsconfig.tc.cli.json

error TS2345: Argument of type '(this: string, separator: unknown, limit?: number) => string[]' is not assignable to parameter of type '(splitter: { [Symbol.split](string: unknown, limit?: unknown): unknown; }, limit?: unknown) => unknown'.
- src/shared/git-history-message-allocation.test.ts#L21 in config/tsconfig.tc.cli.json

config/tsconfig.tc.web.json

error TS2345: Argument of type '(this: string, separator: unknown, limit?: number) => string[]' is not assignable to parameter of type '(splitter: { [Symbol.split](string: unknown, limit?: unknown): unknown; }, limit?: unknown) => unknown'.
- src/shared/git-history-message-allocation.test.ts#L21 in config/tsconfig.tc.web.json

typescript-automation · 2026-09-25T05:30:39Z

Hey Daniel Rosenwasser (@DanielRosenwasser), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

Loosen lib types for string methods that internally call %Symbol.*% m…

677fd91

…ethods

Copilot AI balanced review requested due to automatic review settings September 25, 2026 00:01

github-project-automation Bot added this to PR Backlog Sep 25, 2026

typescript-automation Bot assigned Ryan Cavanaugh (RyanCavanaugh) Sep 25, 2026

typescript-automation Bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 25, 2026

Copilot started reviewing on behalf of graphemecluster (graphemecluster) September 25, 2026 00:02 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

graphemecluster (graphemecluster) mentioned this pull request Sep 25, 2026

Accept union replacement values in String.replace #64330

Draft

Daniel Rosenwasser (DanielRosenwasser) reviewed Sep 25, 2026

View reviewed changes

Conversation

graphemecluster (graphemecluster) commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Sep 25, 2026

Uh oh!

typescript-automation Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-automation Bot commented Sep 25, 2026

tsc

Uh oh!

typescript-automation Bot commented Sep 25, 2026

Uh oh!

typescript-automation Bot commented Sep 25, 2026

Uh oh!

typescript-automation Bot commented Sep 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

graphemecluster (graphemecluster) commented Sep 25, 2026 •

edited

Loading

typescript-automation Bot commented Sep 25, 2026 •

edited

Loading