Fix false implicit-any errors in annotated nested bindings - #64440
Draft
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 9 commits into
Draft
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 9 commits into
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 9 commits into
Conversation
Copilot started work on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 24, 2026 23:09
View session
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TS7031 false positive for nested object binding pattern
Fix false implicit-any errors in annotated nested bindings
Sep 24, 2026
Member
|
Copilot mcfly this and also explain why this is a correct fix |
Copilot started work on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 25, 2026 15:50
View session
This reverts commit 2970fae. Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Contributor
|
I had my agent check this fix. Here's what it has to say about it. Tried this against the cases we hit in our codebase. It clears all of them, and it also gets the types right in a nested callback case ( Two cases still differ from 6.0.3: // 1. Contextual type is `any`: TS7031 on `a` (6.0.3: clean)
declare function anyCb(cb: (x: any) => void): void;
anyCb(({a} = {}) => { void a; });
// 2. One element missing from the contextual type: TS7031 on `q` too (6.0.3: only TS2339 on `extra`)
interface Opts { q?: string; }
declare function onTab(cb: (id: string, opts?: Opts) => void): void;
onTab((id, {q, extra} = {}) => { void [id, q, extra]; });(2) happens because Also, the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested object bindings with
= {}incorrectly reported TS7031 despite an enclosing parameter annotation supplying the binding element type.Cause
Change
= {}default in an annotated parameter (regression from #64043) #64431