fix(64421): convert nested rest bindings to assignment targets - #64422
Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
September 24, 2026 09:31
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted conversion is correct and covered across both affected transformation paths.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes compiler panics when converting nested rest binding patterns into assignment targets.
Changes:
- Converts nested rest binding names before creating spread elements.
- Adds regression coverage for
usingand exported destructuring. - Adds corresponding emit, type, and symbol baselines.
| File | Description |
|---|---|
tsc/internal/transformers/utilities.go |
Converts nested rest targets into assignment patterns. |
tsc/testdata/tests/cases/compiler/usingDeclarationsNestedRest.ts |
Tests the reported using transformation crash. |
tsc/testdata/tests/cases/compiler/exportDestructuringIterator.ts |
Tests exported nested rest destructuring. |
tsc/testdata/baselines/reference/compiler/usingDeclarationsNestedRest.js |
Captures corrected JavaScript emit. |
tsc/testdata/baselines/reference/compiler/usingDeclarationsNestedRest.types |
Captures inferred types. |
tsc/testdata/baselines/reference/compiler/usingDeclarationsNestedRest.symbols |
Captures bound symbols. |
tsc/testdata/baselines/reference/compiler/exportDestructuringIterator.js |
Captures CommonJS export emit. |
tsc/testdata/baselines/reference/compiler/exportDestructuringIterator.types |
Captures exported binding types. |
tsc/testdata/baselines/reference/compiler/exportDestructuringIterator.symbols |
Captures exported binding symbols. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
typescript-automation
Bot
added
For Backlog Bug
Ryan Cavanaugh (RyanCavanaugh)
requested a review
from Wesley Wigham (weswigham)
September 25, 2026 18:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64421