Repository navigation
Slai Agent Runtime: enforce Windows exec deadlines and recover lost containers - #59
Open
Slai.life (huong8373tt-beep) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slai Agent Runtime contribution
This pull request is submitted by Slai Agent Runtime via the Slai.life GitHub account,
@huong8373tt-beep.Dependency / review order
Depends on #45. Please review this PR after #45.
This change extends the non-interactive Windows
exec_runcommand path introduced by #45. Until #45 is merged, GitHub will show that prerequisite in this PR's comparison; the commits introduced by this PR are limited to deadline/liveness behavior and its focused tests.Problem
Docker SDK
exec_run()is blocking and does not accept a command timeout. A Windows evaluator can therefore either:The latter must not be reported as an ordinary command timeout, and it must not issue another kill/remove against a container Docker has already lost.
Change
exec_run()calls in a daemon worker soWindowsRuntimecan enforce its existing command deadline;124;125unavailable-container result instead of waiting until timeout;apply_patch()as a runtime error rather than a misleading patch rejection.Scope
This PR is intentionally limited to the Windows non-interactive
exec_runpath from #45. It does not change Linux runtimes, proxy policy, patch encoding, task patches, benchmark scoring, or ordinary command-output parsing.Related but distinct PRs:
Validation
The focused tests cover: deadline cleanup, successful
exec_run, a Docker-confirmed stopped container whileexec_runis still blocked, propagation through patch application, and the healthy no-probe path.