Repository navigation
Disable SQLite disk sync for test databases - #8748
Draft
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 4 commits into
Draft
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 4 commits into
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8748 +/- ##
=======================================
Coverage 75.42% 75.42%
=======================================
Files 308 308
Lines 32734 32734
=======================================
Hits 24689 24689
Misses 8045 8045 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
test-sqlite-synchronous-off
branch
from
November 10, 2026 19:51
81091eb to
ff30b23
Compare
temporarily_copied_DB and the station config file helpers now create their temporary directories inside the test's tmp_path instead of the system temp dir, so PYTEST_DEBUG_TEMPROOT and --basetemp relocate every temporary file the tests create.
pytest already gives each test a fresh tmp_path and cleans up old ones, so the helpers no longer wrap it in tempfile.TemporaryDirectory. The station config helpers become a single write_config_file function, since there is nothing left to clean up on exit.
Open every QCoDeS connection in the test suite with PRAGMA synchronous=OFF. Test databases are thrown away, so flushing each commit to disk only costs time, which is particularly expensive on Windows.
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
test-sqlite-synchronous-off
branch
from
November 11, 2026 17:50
ff30b23 to
70b96f1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open every QCoDeS connection in the test suite with PRAGMA synchronous=OFF. Test databases are thrown away, so flushing each commit to disk only costs time, which is particularly expensive on Windows.