Repository navigation
FIX Handle a trailing slash on the AzureBlobStorageTarget container URL - #3497
Open
Shivam Sharma (ShivamSharma43) wants to merge 1 commit into
Open
Shivam Sharma (ShivamSharma43) wants to merge 1 commit into
Shivam Sharma (ShivamSharma43) wants to merge 1 commit into
Conversation
With a container URL ending in "/", the returned blob URL had "//" before the file name and named a blob that was never uploaded, and a folder prefix such as "folder/" uploaded the blob as "folder//name". Strip the trailing slash when building the returned URL and the blob prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3495.
AzureBlobStorageTargetbuilt the returned URL asself._container_url + "/" + file_name. With a container URL that ends in/, such ashttps://acct.blob.core.windows.net/xpia/, the URL was.../xpia//doc.txt, which names a blob/doc.txt. The blob was actually uploaded asdoc.txt, so the returned URL pointed at a blob that does not exist. With a folder prefix (.../xpia/folder/),_parse_urlreturned the prefixfolder/and the blob itself was uploaded asfolder//doc.txt.Changes:
_parse_urlstrips slashes from the blob prefix, sofolder/becomesfolderand the blob is uploaded asfolder/doc.txt.URLs without a trailing slash produce the same blob path and URL as before. The stored
container_urland the target identifier are unchanged.Tests and Documentation
tests/unit/prompt_target/target/test_prompt_target_azure_blob_storage.py: for a container URL with and without a trailing slash, and with and without a folder prefix, it checks the container client URL, the uploaded blob path and the returned URL.mainthe two trailing-slash cases fail; with this change all four pass.pytest tests/unit/prompt_target: 1829 passed, 247 skipped.ruff check,ruff formatandty checkpass on the changed files.🤖 Generated with Claude Code