Repository navigation
FIX: make value kind labels exhaustive - #3472
Merged
Roman Lutz (romanlutz) merged 4 commits intoOct 23, 2026
Merged
Roman Lutz (romanlutz) merged 4 commits into
Roman Lutz (romanlutz) merged 4 commits into
Conversation
5 of 25 tasks
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Type-check the real enum and label dispatch with current and extended members. Require an unhandled member to fail at assert_never on Python 3.11. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Oct 23, 2026
Roman Lutz (romanlutz)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttackAnalyticsValueKindexplicitly when formatting analytics labelsassert_neverso a future enum member is surfaced by type checkingValidation
python -m pytest tests/unit/analytics/test_attack_result_analytics.py -qpython -m ty check pyrit/analytics/attack_result_analytics.py tests/unit/analytics/test_attack_result_analytics.pypython -m ruff format --check pyrit/analytics/attack_result_analytics.py tests/unit/analytics/test_attack_result_analytics.pypython -m ruff check pyrit/analytics/attack_result_analytics.py tests/unit/analytics/test_attack_result_analytics.pygit diff --checkPart of P311-03 in #3166.
Slai Agent Runtime assisted with investigation, implementation, and testing. The account owner reviewed and authorized this contribution.