Repository navigation
[DO NOT MERGE] Copy of #2735 - #2771
Draft
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Draft
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Conversation
Workflow resources found in the run config were all mounted into the container read-write. Input models, data files and user scripts only need to be read, so they are now mounted with `:ro`. Only `engine.output_dir` and the engine cache directory stay writable. The temporary config.json and the runner script mounts are read-only as well. Also document that `hf_token: true` passes the full HuggingFace token into the container environment for the Docker system. Fixes #2675
- Match writable resources by config field name (output_dir, cache_dir, logging_dir, sample_log_dir) instead of only engine keys, so existing LoRA/QLoRA training output dirs and evaluator sample log dirs are not mounted read-only. - An input that lives inside a writable directory (for example under the default output dir, which is the working directory) was still writable through that directory's mount. Bind it read-only at its nested location as well so the read-only mount shadows the writable view.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Independent copy of #2735: Mount Docker system input resources read-only.
Copies
Iyanuoluwa007/Olive:docker-readonly-input-mountsto the same branch name inmicrosoft/Olive, preserving the original commits. The original PR remains unchanged.Validation: the copied branch head matches the source PR head. Tests and
lintrunner -awere not run for this copy-only operation; the existing code has not been revalidated.Checklist before requesting a review
lintrunner -a(Optional) Issue link
Source PR: #2735.