Repository navigation
[DO NOT MERGE] Copy of #2738 - #2768
Draft
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Draft
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Conversation
From the CLI quick fixes in the codebase review: - The auto-opt deprecation warning was emitted through logger.warning, which the default --log_level (ERROR) hides, so users never saw it. Print it to stderr instead, and add a deprecation note to the auto-opt how-to page and the CLI reference. - quantize printed internal "pass list" and "selected pass configs" debug output to stdout. Log them at debug level instead, and send the dataset-required warning to stderr. - run-pass --list_passes now prints its error message to stderr. Part of #2516
The quantize debug diagnostics are logged while the run config is generated, but the requested log level was only applied later by the workflow runner (and never for dry runs), so `--log_level 0` still dropped them. Set the Olive logger level at the start of _run_workflow.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Independent copy of #2738: Show the auto-opt deprecation notice and clean up CLI debug output.
Copies
Iyanuoluwa007/Olive:review-quick-fixesto the same branch name inmicrosoft/Olive, preserving the original commits. The original PR remains unchanged.Validation: the copied branch head matches the source PR head. Tests and
lintrunner -awere not run for this copy-only operation; the existing code has not been revalidated.Checklist before requesting a review
lintrunner -a(Optional) Issue link
Source PR: #2738.