Repository navigation
[DO NOT MERGE] Copy of #2740 - #2766
Draft
Xiaoyu Z (xiaoyu-work) wants to merge 1 commit into
Draft
Xiaoyu Z (xiaoyu-work) wants to merge 1 commit into
Xiaoyu Z (xiaoyu-work) wants to merge 1 commit into
Conversation
transformers picks the grouped_mm fused-experts forward by default, even on CPU. It transposes the expert weight, which a storage-only QuantTensor can't do, so running a reloaded Rtn/Gptq/KQuant(moe=True) checkpoint crashed with "Shape-movement / view ops ... are not supported on an Olive QuantTensor". save_pretrained doesn't persist the experts implementation, so finalize() now writes "experts_implementation": "eager" to the saved config.json (after save_metadata, which rewrites that file). from_pretrained then loads the checkpoint with the eager forward, which uses the weight without moving it. Fixes #2619
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Independent copy of #2740: Pin the eager experts implementation in moe=True quantized checkpoints.
Copies
Iyanuoluwa007/Olive:pin-eager-experts-for-moe-quantto the same branch name inmicrosoft/Olive, preserving the original commits. The original PR remains unchanged.Validation: the copied branch head matches the source PR head. Tests and
lintrunner -awere not run for this copy-only operation; the existing code has not been revalidated.Checklist before requesting a review
lintrunner -a(Optional) Issue link
Source PR: #2740.