Repository navigation
fix(evaluations): migrate maker connection discovery to PPAPI - #514
Draft
Apurva Banka (apurvabanka) wants to merge 1 commit into
Draft
Apurva Banka (apurvabanka) wants to merge 1 commit into
Apurva Banka (apurvabanka) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61fd0c13-7208-4a76-ab52-1029d3184801
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate Dataverse-backed evaluation maker connection discovery from the legacy PowerApps API to the supported environment-scoped PPAPI
/connectivity/connectors/{connector}/connectionsroute. This covers Copilot Studio profile discovery for listing/running evaluations and optional agent-tool connection discovery.417219b4-3a7d-42a2-bdb1-972bd8281a02public client and existing authentication helpers with the named delegatedConnectivity.Connections.Readscope and shared token-cache path.Default-<GUID>environment identities using the existing host derivation.The maker contract is recorded in ADO task 7985149. Environment-wide delegated admin discovery remains unresolved and is deliberately not substituted with maker-visible results or S2S authentication. This is only the maker portion of task 7985151; neither task nor the parent story is completed by this PR. No new permission grant or deployment is included; existing-grant reconciliation and controlled live verification remain separate.
Telemetry impact review: no telemetry impact. No CLI entry point, outcome/status bucket, stable telemetry field, scope/category dimension, or emitter contract is added or changed.
Related issue
Refs ADO task 7985151 (maker portion only) and contract task 7985149.
Type of change
Testing
All commands ran from the repository root. Tests used
ESS_ADK_TELEMETRY=off; new discovery tests use fake MSAL, temporary cache state, and blocked network requests.python -m pytest tests\scripts\test_evaluation_runs.py tests\scripts\test_agentbuilder.py tests\flightcheck\test_pp_admin_client.py tests\flightcheck\checks\test_servicenow_da_hrsd.py tests\flightcheck\checks\test_servicenow_da_itsm.py -q --tb=short— passed: 401 tests.python -m ruff check solutions\ess-maker-skills\scripts\agentbuilder.py solutions\ess-maker-skills\scripts\evaluation_runs.py tests\scripts\test_agentbuilder.py tests\scripts\test_evaluation_runs.py— passed.python -m compileall -q solutions\ess-maker-skills\scripts\agentbuilder.py solutions\ess-maker-skills\scripts\evaluation_runs.py— passed.git --no-pager diff --check— passed.Focused cases cover exact client/scope/authority and account selection, wrong-account/tenant and auth-denial failures, target binding, shared-profile selection, default environments, short/empty continuation pages, unsafe/repeated continuations, and failures after a successful first page. Existing admin-client and native ServiceNow connector regressions remain passing.
The owner-linked current OpenAPI collection/item schema was inspected while implementing the client behavior. No live tenant sign-in/API call, permission deployment, evaluation start, or full E2E authorization verification was performed. Full repository suites were not run.
Checklist
Static validation (samples/ only)