Repository navigation
org-announcements: add shared telemetry and Vorpal bridge (CA) - #503
Open
Asher Johnson Hogan (asherjh) wants to merge 1 commit into
Conversation
Connect announcement server and widget events to correlated ADK telemetry while retaining content-free diagnostics, validated write receipts, and the CA announcement and title-resolution contracts. - Reuse the shared SDK and native MCP operation telemetry foundation. - Register the app-only report_client_events bridge on the widget server. - Correlate configuration, Graph, and synchronous Dataverse transport calls. - Give title resolution one operation record while preserving default Dataverse telemetry. - Preserve committed-write state through failed reloads and cancellation. - Cover privacy, same-connection ingestion, operation correlation, and regular/LOB title behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 304fe4ee-01c6-4d09-8ecc-0e2f25c27855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Org Announcements exposes the app-only
report_client_eventsVorpal bridge on its widget-hosting MCP connection and uses the shared ADK operation telemetry foundation. Announcement tool calls carry correlated server-operation/request IDs, authenticated tenant context, HTTP outcomes, retry/auth-refresh measurements, content-free usage, and confirmed-write state.This PR targets
users/sophiesong/org-announcements-main-ca-local, the source branch of the CA companion promotion. Dataverse measurements cover the synchronous SDK transport call; urllib3-managed retries retain the existing session policy.Related issue
Refs #382 — [main-ca companion] Add Org Announcements authoring support.
Refs #437 — agentconfig-mcp: add shared LPC operation telemetry (main-ca).
Type of change
Testing
Local validation used Python 3.14 and repository-pinned Ruff 0.16.0.
python -m pytest tests\mcp\agentconfig_org_announcements tests\mcp\agentconfig_core tests\mcp\agentconfig tests\mcp\test_import_isolation.py tests\scripts\test_mcp_config.py tests\scripts\test_auth.py tests\setup\test_org_announcements_integration.py tests\test_adk_mcp_report_client_events.py tests\test_adk_telemetry.py -q -p no:cacheprovider --tb=line— 1,638 passed; 22 skipped (21 live-network tests and one POSIX-permission test); one existing cancellation test failed.python -m pytest tests\mcp\agentconfig_org_announcements\test_agent_title.py::test_cancelled_sign_in_cannot_accumulate_workers_or_independent_retries -q -p no:cacheprovider— failed identically on untouched target commit9facbfd12350242fc1facc6f9d8c50f92a3ebf14: Python 3.14 reports an unhandledToolError exception in shielded futureafter cancelled sign-in. The coordinator is unchanged.python -m ruff check solutions\ess-maker-skills\scripts solutions\ess-maker-skills\src\mcp --output-format=github— passed.python -m compileall -q solutions\ess-maker-skills\scripts solutions\ess-maker-skills\src\mcp— passed.python -m pre_commit run --hook-stage pre-commit— passed with the repository-pinned Ruff hook.git diff --cached --check— passed.All added telemetry/bridge regressions passed, including successful, forbidden, and network-failed Dataverse title lookups. Native MCP memory-transport and stdio initialization tests passed. Live Vorpal/tenant/collector validation was not run. Repository CI triggers on
main,main-ca, andrelease/**targets; this feature-branch target is outside that filter.Checklist
Static validation (samples/ only)
No changes under
samples/.