Skip to content

org-announcements: add shared telemetry and Vorpal bridge (CA) - #503

Open
Asher Johnson Hogan (asherjh) wants to merge 1 commit into
users/sophiesong/org-announcements-main-ca-localfrom
users/asherj/org-announcements-telemetry-ca
Open

Asher Johnson Hogan (asherjh) wants to merge 1 commit into
users/sophiesong/org-announcements-main-ca-localfrom
users/asherj/org-announcements-telemetry-ca

Conversation

@asherjh

Copy link
Copy Markdown
Contributor

Description

Org Announcements exposes the app-only report_client_events Vorpal bridge on its widget-hosting MCP connection and uses the shared ADK operation telemetry foundation. Announcement tool calls carry correlated server-operation/request IDs, authenticated tenant context, HTTP outcomes, retry/auth-refresh measurements, content-free usage, and confirmed-write state.

  • Reuses the shared SDK/MCP foundation from agentconfig-mcp: add shared LPC operation telemetry (main-ca) #437 — agentconfig-mcp: add shared LPC operation telemetry (main-ca).
  • Registers schema-v2 client-event ingestion with accepted/rejected verdicts and excludes the bridge from business-operation telemetry.
  • Correlates AgentConfiguration and Graph transport calls and preserves validated OData receipts, canonical reloads, write retry policy, and client leases.
  • Gives CA title resolution one correlated operation record and synchronous Dataverse transport measurements; the Dataverse observer owns telemetry for that call, and the default helper retains its existing behavior.
  • Preserves regular/LOB title resolution, tenant/account binding, bounded sign-in, and shared-worker cancellation semantics.
  • Covers native MCP same-connection ingestion, operation/HTTP correlation, privacy, cancellation, failed receipts, and committed refresh failures.

This PR targets users/sophiesong/org-announcements-main-ca-local, the source branch of the CA companion promotion. Dataverse measurements cover the synchronous SDK transport call; urllib3-managed retries retain the existing session policy.

Related issue

Refs #382 — [main-ca companion] Add Org Announcements authoring support.
Refs #437 — agentconfig-mcp: add shared LPC operation telemetry (main-ca).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor / cleanup

Testing

Local validation used Python 3.14 and repository-pinned Ruff 0.16.0.

  • python -m pytest tests\mcp\agentconfig_org_announcements tests\mcp\agentconfig_core tests\mcp\agentconfig tests\mcp\test_import_isolation.py tests\scripts\test_mcp_config.py tests\scripts\test_auth.py tests\setup\test_org_announcements_integration.py tests\test_adk_mcp_report_client_events.py tests\test_adk_telemetry.py -q -p no:cacheprovider --tb=line — 1,638 passed; 22 skipped (21 live-network tests and one POSIX-permission test); one existing cancellation test failed.
  • python -m pytest tests\mcp\agentconfig_org_announcements\test_agent_title.py::test_cancelled_sign_in_cannot_accumulate_workers_or_independent_retries -q -p no:cacheprovider — failed identically on untouched target commit 9facbfd12350242fc1facc6f9d8c50f92a3ebf14: Python 3.14 reports an unhandled ToolError exception in shielded future after cancelled sign-in. The coordinator is unchanged.
  • python -m ruff check solutions\ess-maker-skills\scripts solutions\ess-maker-skills\src\mcp --output-format=github — passed.
  • python -m compileall -q solutions\ess-maker-skills\scripts solutions\ess-maker-skills\src\mcp — passed.
  • python -m pre_commit run --hook-stage pre-commit — passed with the repository-pinned Ruff hook.
  • git diff --cached --check — passed.

All added telemetry/bridge regressions passed, including successful, forbidden, and network-failed Dataverse title lookups. Native MCP memory-transport and stdio initialization tests passed. Live Vorpal/tenant/collector validation was not run. Repository CI triggers on main, main-ca, and release/** targets; this feature-branch target is outside that filter.

Checklist

  • My code follows the existing style
  • I have added/updated tests where applicable
  • I have updated documentation as needed

Static validation (samples/ only)

No changes under samples/.

Validation
- YAML parse: N-A
- AdaptiveDialog kind: N-A
- XML parse: N-A
- Filename convention (new): N-A
- Folder convention (new, incl. README.md): N-A
- Diff scope (samples/ only): N-A
- Secrets / internal URLs: N-A

Connect announcement server and widget events to correlated ADK telemetry while retaining content-free diagnostics, validated write receipts, and the CA announcement and title-resolution contracts.

- Reuse the shared SDK and native MCP operation telemetry foundation.
- Register the app-only report_client_events bridge on the widget server.
- Correlate configuration, Graph, and synchronous Dataverse transport calls.
- Give title resolution one operation record while preserving default Dataverse telemetry.
- Preserve committed-write state through failed reloads and cancellation.
- Cover privacy, same-connection ingestion, operation correlation, and regular/LOB title behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 304fe4ee-01c6-4d09-8ecc-0e2f25c27855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant