Repository navigation
fix(tests): correct release E2E image tag and telemetry checks - #1836
Open
zanejohnson-azure wants to merge 1 commit into
Open
zanejohnson-azure wants to merge 1 commit into
zanejohnson-azure wants to merge 1 commit into
Conversation
Validate inventory tags against Kubernetes image references, anchor startup traces to deployment time, and pin Testkube to the checked-out commit. Preserve recent heartbeat and metric checks and fail closed on workflow setup errors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the two recurring false-positive E2E failures observed in both the 3.9.1 release run 130085 and the 3.10.0 release run 131881. Agent image behavior is unchanged.
ContainerInventory.ImageTagagainst each Kubernetes container's original image reference, matched by container ID for regular and init containers. Permit empty tags only for confirmed digest-only references; retain explicit-tag and implicit-latestvalidation. An unknown container with an empty tag still fails.TELEMETRY_TAGoverrides.Image-tag validation behavior
The test matches each inventory record to its Kubernetes container by
ContainerID, then parses the original image reference:app:1.2ImageTagmust equal1.2app:1.2@sha256:…1.2app@sha256:…ImageTagis allowedappImageTagmust equallatestThe separate
Image,ImageID, andRepositorychecks still run. If an empty tag cannot be matched to a Kubernetes image reference, it still fails.Validation
go test ./...intest/ginkgo-e2e/utils: passed.bash test/testkube/install-and-execute-testkube-tests_test.sh: passed.Ran the locally compiled querylogs and containerstatus suites read-only against the unchanged
3.10.0-ci-prod-11-10-2026-c75cc056deployment:Workload identity passed every changed assertion. Its successful earlier pipeline run had removed Testkube, and the standalone rerun found no persistent volumes or active application log producers. The unchanged ContainerLog and KubePVInventory checks were deliberately not weakened. Normal release testing installs Testkube and its fixtures before executing these checks.
All four previously failing clusters now pass both suites. Final all-five-cluster confirmation still requires the normal deploy/test pipeline with its fixtures. That stage is gated to non-PR
ci_prodruns.